Skip to content

feat: add base support for path text#223

Merged
Agamnentzar merged 2 commits intoAgamnentzar:masterfrom
quarksb:master
Feb 24, 2025
Merged

feat: add base support for path text#223
Agamnentzar merged 2 commits intoAgamnentzar:masterfrom
quarksb:master

Conversation

@quarksb
Copy link
Contributor

@quarksb quarksb commented Feb 6, 2025

Resolve #168

@Agamnentzar
Copy link
Owner

Can you supply PSD file with some text on curves for tests

@quarksb
Copy link
Contributor Author

quarksb commented Feb 7, 2025

I can't attach psd file due to github has limited the file type, so I will send it by email, please check your email

@Agamnentzar
Copy link
Owner

EngineData type only works for per-layer engine data field, it doesn't match the of the global engine data. This field doesn't exist: globalEngineData?.ResourceDict?.TextFrameSet. Insted the curve data is probably somewhere in globalEngineData.EngineDict['Editors?'][0]['FontVectorData ???']

@quarksb
Copy link
Contributor Author

quarksb commented Feb 17, 2025

sorry for answer so lately, I was trapped by work last week.
I believe this field exist: globalEngineData?.ResourceDict?.TextFrameSet. but since ResourceDict is not an array but an object, so I shoud us Object.keys(ResourceDict).length instead of ResourceDict.length to figure out whether it's empty.
image

@Agamnentzar
Copy link
Owner

Hmm, ok, I didn't notice up updated some keys in engineData2.ts, can you change back spaces to tabs so the diff is correct. Also layer.effects field in layer is for blending effects, you should put curves into layer.text.curves instead. Also my comment about EngineData type still stands, instead you can create GlobalEngineData type for that data.

@quarksb
Copy link
Contributor Author

quarksb commented Feb 17, 2025

can you give me your prettier config to help me change back spaces to tabs so the diff is correct, sorry to formmat this code

@Agamnentzar
Copy link
Owner

can you give me your prettier config to help me change back spaces to tabs so the diff is correct, sorry to formmat this code

I use default typescript formatting in vscode

@quarksb
Copy link
Contributor Author

quarksb commented Feb 17, 2025

ok, I will perfect this pr later, since I have to do my job now

@quarksb quarksb changed the title [WIP]feat: add base support for path text feat: add base support for path text Feb 19, 2025
@quarksb
Copy link
Contributor Author

quarksb commented Feb 19, 2025

I have update my pr, except GlobalEngineData, In my opinion, we can reuse EngineData, since there is no clear difference between GlobalEngineData and EngineData.
of course, you can change the code as you wish

@Agamnentzar Agamnentzar merged commit 8e1530f into Agamnentzar:master Feb 24, 2025
@Agamnentzar
Copy link
Owner

I think the name field might not be labelled correctly
image

@Agamnentzar
Copy link
Owner

@quarksb Just released version 27.0.0 with support for layer.text.textPath field. I changed field names to lowercase to keep consistent with rest of the types and adjusted types a bit.

@Agamnentzar Agamnentzar self-requested a review February 24, 2025 23:30
@quarksb
Copy link
Contributor Author

quarksb commented Feb 25, 2025

could you give me more info about this?

I think the name field might not be labelled correctly image

@Agamnentzar
Copy link
Owner

I can't find that anymore for some reason, maybe it was a fluke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can not find pen tool path information

2 participants