fix(tool): honor SSL verify toggles for API services#193
Merged
Conversation
Wire the OneSEC, NGTIP, and Qingteng API handlers to respect the configured SSL verification toggle so private deployments can bypass certificate checks when needed. Add regression tests that cover both enabled and disabled verification paths and isolate Qingteng tests from local machine config. Made-with: Cursor
duguwanglong
approved these changes
Apr 27, 2026
duguwanglong
added a commit
that referenced
this pull request
Apr 29, 2026
- Add `_resolve_verify_ssl` helper that reads `verify_ssl` / `ssl_verify` / `custom_settings.verify_ssl` (matches the onesec/qingteng/ngtip pattern from PR #193). The bottom "SSL 验证" form toggle writes to `custom_settings.verify_ssl`, which the handler previously ignored — causing the toggle to have no effect at runtime. - Drop the standalone `verify_ssl` credential_field from _provider.yaml so the WebUI no longer renders a duplicate text input next to the bottom SSL toggle. - Refresh _provider.yaml notes to describe the new SSL toggle resolution precedence.
duguwanglong
pushed a commit
to DearEmma/flocks
that referenced
this pull request
May 18, 2026
Wire the OneSEC, NGTIP, and Qingteng API handlers to respect the configured SSL verification toggle so private deployments can bypass certificate checks when needed. Add regression tests that cover both enabled and disabled verification paths and isolate Qingteng tests from local machine config.
duguwanglong
added a commit
to DearEmma/flocks
that referenced
this pull request
May 18, 2026
- Add `_resolve_verify_ssl` helper that reads `verify_ssl` / `ssl_verify` / `custom_settings.verify_ssl` (matches the onesec/qingteng/ngtip pattern from PR AgentFlocks#193). The bottom "SSL 验证" form toggle writes to `custom_settings.verify_ssl`, which the handler previously ignored — causing the toggle to have no effect at runtime. - Drop the standalone `verify_ssl` credential_field from _provider.yaml so the WebUI no longer renders a duplicate text input next to the bottom SSL toggle. - Refresh _provider.yaml notes to describe the new SSL toggle resolution precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
uv run pytest tests/tool/test_onesec_api_tool.pyuv run pytest tests/tool/test_ngtip_api_tool.py tests/tool/test_qingteng_api_tool.pyMade with Cursor