refactor(platform-integrations): namespace shared lib under lib/evolve-lite/ - #258
Merged
Conversation
…e-lite/ The shared lib (entity_io, config, audit) now renders to lib/evolve-lite/ on every host instead of a bare lib/ — and .bob/lib/evolve-lite/ for bob, replacing .bob/evolve-lib/. Skill scripts resolve it by walking ancestors for lib/evolve-lite/, so multiple plugins can share a host's lib/ directory without their modules colliding. The canonical source stays flat (plugin-source/lib/); build_plugins.py applies a shared target rewrite to namespace it at render time. install.sh and the platform-integration tests are updated to the new layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughStandardizes the plugin shared-library layout to lib/evolve-lite/ across build output, platform integrations (Bob, Claude, Claw, Codex), installer, tests, and docs; scripts now search ancestor paths for lib/evolve-lite/entity_io.py and the build emits lib/evolve-lite/ via a shared rewrite. ChangesShared Library Path Standardization
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugin-source/_bob/README.md (1)
23-23: ⚡ Quick winUse consistent path notation with line 22.
Line 22 documents the skills directory as
~/.bob/skills/(absolute path with tilde), but this line uses.bob/lib/evolve-lite/(relative path). For consistency, since Bob installs to the user's home directory, both should use the same notation.📝 Suggested fix
-- Shared library in `.bob/lib/evolve-lite/` +- Shared library in `~/.bob/lib/evolve-lite/`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@plugin-source/_bob/README.md` at line 23, Update the path notation for the shared library entry so it matches the absolute-tilde style used on line 22: replace the string ".bob/lib/evolve-lite/" with "~/.bob/lib/evolve-lite/" in the README (ensure you update the exact text ".bob/lib/evolve-lite/" to the tilde-prefixed "~/.bob/lib/evolve-lite/" so both entries use the same notation as "~/.bob/skills/").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platform-integrations/install.sh`:
- Line 1072: The printed status message is inconsistent: the existence check
uses (plugin_dir / 'lib' / 'evolve-lite' / 'entity_io.py') but the printed label
shows "lib/entity_io.py"; update the printed label to match the actual path
being checked (e.g., "lib/evolve-lite/entity_io.py") in the print statement so
the output accurately reflects the checked file; locate the print(...) call that
contains "lib/entity_io.py" and change only the displayed path string to match
the checked path.
---
Nitpick comments:
In `@plugin-source/_bob/README.md`:
- Line 23: Update the path notation for the shared library entry so it matches
the absolute-tilde style used on line 22: replace the string
".bob/lib/evolve-lite/" with "~/.bob/lib/evolve-lite/" in the README (ensure you
update the exact text ".bob/lib/evolve-lite/" to the tilde-prefixed
"~/.bob/lib/evolve-lite/" so both entries use the same notation as
"~/.bob/skills/").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 178777f9-09ba-47ce-8c34-496242a4ab14
📒 Files selected for processing (66)
platform-integrations/INSTALL_SPEC.mdplatform-integrations/bob/evolve-lite/README.mdplatform-integrations/bob/evolve-lite/lib/evolve-lite/__init__.pyplatform-integrations/bob/evolve-lite/lib/evolve-lite/audit.pyplatform-integrations/bob/evolve-lite/lib/evolve-lite/config.pyplatform-integrations/bob/evolve-lite/lib/evolve-lite/entity_io.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-learn/scripts/save_entities.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-provenance/scripts/log_influence.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-publish/scripts/publish.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-recall/scripts/retrieve_entities.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-subscribe/scripts/subscribe.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-sync/scripts/sync.pyplatform-integrations/bob/evolve-lite/skills/evolve-lite-unsubscribe/scripts/unsubscribe.pyplatform-integrations/claude/plugins/evolve-lite/lib/evolve-lite/__init__.pyplatform-integrations/claude/plugins/evolve-lite/lib/evolve-lite/audit.pyplatform-integrations/claude/plugins/evolve-lite/lib/evolve-lite/config.pyplatform-integrations/claude/plugins/evolve-lite/lib/evolve-lite/entity_io.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/learn/scripts/save_entities.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/provenance/scripts/log_influence.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/publish/scripts/publish.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/recall/scripts/retrieve_entities.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/subscribe/scripts/subscribe.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/sync/scripts/sync.pyplatform-integrations/claude/plugins/evolve-lite/skills/evolve-lite/unsubscribe/scripts/unsubscribe.pyplatform-integrations/claw-code/plugins/evolve-lite/lib/evolve-lite/__init__.pyplatform-integrations/claw-code/plugins/evolve-lite/lib/evolve-lite/audit.pyplatform-integrations/claw-code/plugins/evolve-lite/lib/evolve-lite/config.pyplatform-integrations/claw-code/plugins/evolve-lite/lib/evolve-lite/entity_io.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/learn/scripts/save_entities.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/provenance/scripts/log_influence.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/publish/scripts/publish.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/recall/scripts/retrieve_entities.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/subscribe/scripts/subscribe.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/sync/scripts/sync.pyplatform-integrations/claw-code/plugins/evolve-lite/skills/evolve-lite/unsubscribe/scripts/unsubscribe.pyplatform-integrations/codex/plugins/evolve-lite/lib/evolve-lite/__init__.pyplatform-integrations/codex/plugins/evolve-lite/lib/evolve-lite/audit.pyplatform-integrations/codex/plugins/evolve-lite/lib/evolve-lite/config.pyplatform-integrations/codex/plugins/evolve-lite/lib/evolve-lite/entity_io.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/learn/scripts/save_entities.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/provenance/scripts/log_influence.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/publish/scripts/publish.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/recall/scripts/retrieve_entities.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/subscribe/scripts/subscribe.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/sync/scripts/sync.pyplatform-integrations/codex/plugins/evolve-lite/skills/evolve-lite/unsubscribe/scripts/unsubscribe.pyplatform-integrations/install.shplugin-source/_bob/README.mdplugin-source/build_plugins.pyplugin-source/skills/evolve-lite/learn/scripts/save_entities.pyplugin-source/skills/evolve-lite/provenance/scripts/log_influence.pyplugin-source/skills/evolve-lite/publish/scripts/publish.pyplugin-source/skills/evolve-lite/recall/scripts/retrieve_entities.py.j2plugin-source/skills/evolve-lite/subscribe/scripts/subscribe.pyplugin-source/skills/evolve-lite/sync/scripts/sync.pyplugin-source/skills/evolve-lite/unsubscribe/scripts/unsubscribe.pytests/platform_integrations/AGENTS.mdtests/platform_integrations/test_audit.pytests/platform_integrations/test_bob_sharing.pytests/platform_integrations/test_codex.pytests/platform_integrations/test_config.pytests/platform_integrations/test_entity_io.pytests/platform_integrations/test_entity_io_core.pytests/platform_integrations/test_idempotency.pytests/platform_integrations/test_plugin_structure.pytests/platform_integrations/test_subscribe.py
… path notation Address CodeRabbit review on #258: - install.sh: codex status line label now matches the path it checks (lib/evolve-lite/entity_io), consistent with the bob status line. - _bob/README.md: shared-library path uses ~/.bob/ tilde notation to match the skills-directory entry above it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Codex ReviewTarget: branch diff against main The relocated Bob library path is not included in Bob's uninstall/purge cleanup, leaving installed artifacts behind after uninstall. The main runtime lookup changes otherwise appear internally consistent. Review comment
|
…e path Two bob-installer correctness fixes surfaced while wiring up global installs: - Uninstall now removes the namespaced shared lib at `.bob/lib/evolve-lite/`. After the lib/ rename it is no longer an evolve-prefixed top-level dir, so the generic purge loop missed it and left artifacts behind (gaodan-fang's PR #258 review). Adds a regression test. - Install/uninstall/status now resolve the custom-mode (and full-mode MCP) file by scope: Bob reads GLOBAL modes from `~/.bob/settings/custom_modes.yaml` but PROJECT modes from `<project>/.bob/custom_modes.yaml`. The installer previously always wrote the top-level path, so a global install (`--dir $HOME`) landed in a file Bob never loads. Uninstall also strips the legacy top-level file so pre-fix installs get cleaned up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vinodmut
added a commit
to vinodmut/kaizen
that referenced
this pull request
Jun 1, 2026
PR AgentToolkit#258 moved each platform's shared lib from `lib/` to `lib/evolve-lite/`. My _lib walker was looking for `lib/audit.py` and `evolve-lib/audit.py` and would fail to find the helpers post-merge. Update the walker to match the simplified pattern used by save_entities and other recall scripts: a single `lib/evolve-lite/` candidate.
vinodmut
added a commit
that referenced
this pull request
Jul 8, 2026
…262) * feat: add synthesize-skill skill for all platforms A new evolve-lite skill that converts a saved trajectory into a reusable agent skill (SKILL.md + supporting scripts). Models the SKILL.md shape on the existing learn skill: judgment lives in a forked subagent (read trajectory, identify the successful workflow, draft a SKILL.md and scripts), file-system plumbing lives in scripts/synthesize.py (frontmatter validation, dual writes, audit-log entry). Lives at plugin-source/skills/evolve-lite/synthesize-skill/ — universal, ships to all four platforms (claude, codex, claw-code, bob). The SKILL.md template uses the shared invoke()/skill_ref() macros for platform-aware shell paths and slash-prefixes; the script is templated to set _RUNTIME_MIRROR_DIR per platform. On claude, the script writes both to .evolve/skills/<name>/ (canonical) and .claude/skills/<name>/ (so the Claude Code skill loader picks it up automatically). Other platforms write only to .evolve/skills/<name>/ for now — adopting an automatic runtime mirror on those hosts is a follow-up. The skill is invoked manually for now; not wired into a Stop hook. * test(experiments): add skill-from-trajectory experiment runner Three-way comparison driver (no_recall / guidelines / skill) that runs the seed → synthesize → measure flow per trial. Reuses helpers from experiments/token_savings.py. Captures token usage from --output-format json plus per-turn usage and tool-call summaries from saved transcripts. Supports --seed-utterances to test multi-utterance seeding (e.g. gps + focal_length, then measure on lens) for skill generalization. Also resolves /tmp -> /private/tmp on macOS (Docker bind-mount of /tmp subdirs doesn't follow the symlink, breaking the prior plumbing for hidden subdirs). * fix(claude-plugin): apply ruff format to synthesize.py Ruff format wants `text[match.end() :]` (slice spacing) instead of `text[match.end():]`. Apply to the .j2 source plus all four rendered outputs so re-running the renderer stays consistent. Fixes failing CI check: check-formatting (3.12) * fix(experiments): apply ruff format to skill_from_trajectory.py Fixes failing CI check: check-formatting (3.12) * fix(experiments): silence mypy on sys.path-hack import The token_savings import goes through sys.path.insert so mypy can't resolve the module. Add `# type: ignore[import-not-found]` and explicitly annotate the wrapper return so the no-any-return error is also resolved. Fixes failing CI check: check-typing (3.12) * fix(claude-plugin): tag SKILL.md fenced blocks with language identifiers Markdownlint MD040 wants every fenced code block to declare a language. The frontmatter example fence becomes ```yaml; the directory-tree fence becomes ```text. Edit the .j2 source so re-rendering propagates to all four platforms. Addresses CodeRabbit review findings: - "Add language identifier to fenced code block" (frontmatter) - "Add language identifier to fenced code block" (directory tree) - "Add language identifiers to fenced code blocks (root cause for deployed copies)" * fix(claude-plugin): harden synthesize.py finalize against partial installs Two robustness fixes in cmd_finalize: 1. Wrap the _parse_frontmatter call in a try/except ValueError so malformed SKILL.md files exit cleanly (SystemExit with the parser's message) instead of bubbling up a traceback. 2. Pre-check both destinations (.evolve/skills/<name>/ and the platform-specific runtime mirror, when set) before performing any copy. Previously, if the runtime-mirror destination already existed and --force was off, evolve_dst would already have been written — leaving a partial install on disk. Refactor: extract _check_dest() (existence guard) from _copy_into() (actual write), and call _check_dest on both targets before either _copy_into. Also collapse the platform-specific _RUNTIME_MIRROR_DIR declaration to a single line so the rendered output matches ruff format directly (no post-render reformatting cycle). Addresses CodeRabbit review findings: - "Frontmatter parse errors escape as tracebacks instead of clean CLI errors" - "Pre-check both destinations before copying to avoid a partial install" - "Partial install on runtime-mirror failure (claude variant)" * fix(claude-plugin): adapt synthesize.py walker to the namespaced lib/ PR #258 moved each platform's shared lib from `lib/` to `lib/evolve-lite/`. My _lib walker was looking for `lib/audit.py` and `evolve-lib/audit.py` and would fail to find the helpers post-merge. Update the walker to match the simplified pattern used by save_entities and other recall scripts: a single `lib/evolve-lite/` candidate. --------- Co-authored-by: Vatche Isahagian <visahak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shared lib (
entity_io,config,audit) now renders tolib/evolve-lite/on every host instead of a barelib/— and.bob/lib/evolve-lite/for bob, replacing.bob/evolve-lib/.Skill scripts resolve the lib by walking ancestors for
lib/evolve-lite/, so multiple plugins can share a host'slib/directory without their modules colliding. This establishes a namespacing standard (lib/<plugin>/) for plugins to coexist.How
plugin-source/lib/).build_plugins.pygains aSHARED_TARGET_REWRITESrule (^lib/→lib/evolve-lite/) applied to every platform at render time, so a new platform inherits it automatically..j2): resolution snippet simplified to a single ancestor-walk forlib/evolve-lite/, dropping the oldlib/evolve-libdual candidates.install.sh: bob copies the lib to.bob/lib/evolve-lite/; bob + codex status lines updated.tests/platform_integrations/.INSTALL_SPEC.md,plugin-source/_bob/README.md,tests/platform_integrations/AGENTS.md.Verification
build_plugins.py check— clean (no drift)🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Refactor
Tests