fix: strengthen pr-reviewer cross-file context prompt#16
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesHarness Prompt Impact Tracing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the review agent's prompt in review/agent.ts to instruct it to trace the impact of code changes across callers, types, tests, and configurations, and to fix breakages even in files outside the changed-file set without performing an unrelated full-repo audit. There are no review comments, so no feedback is provided.
Summary
Assessment
cwd: ctx.sandbox.cwd, and the PR workspace setup creates a real git checkout at that cwd.refs/pull/<number>/head, checks outpr-head, and guards that the worktree remains a git repo..workforce/pr.diffis generated as a three-dot binary diff fromMERGE_BASE...pr-head; for very large diffs cloud caps it atPR_DIFF_MAX_BYTESand appends a truncation notice, so whole-repo context remains important for truncated diffs too.Deployment note
This prompt change requires redeploying the
pr-reviewerpersona to take effect. This PR does not deploy it.Verification
npm run typechecknpm run compileattempted, but the repo script currently fails because the installedagentworkforceCLI does not provide the scriptedpersonasubcommand (Unknown subcommand "persona").Summary by cubic
Strengthens the
pr-reviewerprompt to trace cross-file impact using the checked-out repo. It can now flag and fix breakage in callers, types, tests, and config outside the changed-file list, while staying scoped to this PR (not a full-repo audit).Written for commit 9d76ed2. Summary will update on new commits.
Review in cubic