Skip to content

Stop tracking generated persona JSON artifacts#24

Merged
khaliqgant merged 1 commit into
mainfrom
fix/remove-generated-persona-json
Jun 2, 2026
Merged

Stop tracking generated persona JSON artifacts#24
khaliqgant merged 1 commit into
mainfrom
fix/remove-generated-persona-json

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jun 2, 2026

Copy link
Copy Markdown
Member

User description

Summary

  • Remove the root */persona.json files introduced by Fix Linear implementer comment mention handling #23 for generated persona outputs.
  • Add */persona.json to .gitignore so future npm run compile output stays local.
  • Leave handler code and pre-existing tracked artifacts such as review/.workforce/build/* untouched.

Deploy/compile convention checked

  • Repo docs state the local workflow is: agentworkforce persona compile ./<agent>/persona.ts, then agentworkforce deploy ./<agent>/persona.json --mode cloud.
  • I verified with dry-runs that a committed linear/persona.json is neither required nor sufficient for deploy: both linear/persona.ts and linear/persona.json currently fail the same cloud trigger validation in this repo state, so no persona requires these generated JSON files to be tracked.
  • The correct convention is local compile -> local gitignored persona.json -> deploy; do not commit the generated output.

Validation

  • npm run typecheck
  • npm test
  • npm run compile (confirmed generated root persona JSON files are recreated locally and ignored)
  • git check-ignore --no-index -v granola/persona.json linear/persona.json review/persona.json

Summary by cubic

Stop tracking generated persona.json outputs by removing committed files and adding */persona.json to .gitignore. This keeps compile artifacts local and out of Git history.

Written for commit 8175a69. Summary will update on new commits.

Review in cubic


CodeAnt-AI Description

Stop committing generated persona JSON files

What Changed

  • Removed generated persona.json files from the repo for the affected personas
  • Future persona builds will keep these generated files local instead of checking them into Git

Impact

✅ Cleaner repository history
✅ Fewer accidental commits of generated files
✅ Easier local compile-and-deploy workflow

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai

codeant-ai Bot commented Jun 2, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@khaliqgant, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e2c646c3-e2fa-44de-b4c1-830885846f88

📥 Commits

Reviewing files that changed from the base of the PR and between 1b07350 and 8175a69.

📒 Files selected for processing (7)
  • .gitignore
  • granola/persona.json
  • hn-monitor/persona.json
  • linear/persona.json
  • review/persona.json
  • spotify-releases/persona.json
  • vendor-monitor/persona.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-generated-persona-json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Jun 2, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

@khaliqgant khaliqgant merged commit edfd729 into main Jun 2, 2026
2 checks passed
@khaliqgant khaliqgant deleted the fix/remove-generated-persona-json branch June 2, 2026 20:21
@agent-relay-code

Copy link
Copy Markdown
Contributor

Reviewed PR #24 and fixed one incomplete part of the artifact cleanup: repo-hygiene/persona.json was still present as a generated persona file, so I removed it too.

Local checks run:

  • npm run typecheck passed
  • npm test passed
  • npm run compile passed and regenerated the ignored */persona.json outputs as expected; I cleaned those generated files back out afterward

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer applied fixes — committed and pushed d948ec2 to this PR. The notes below describe what changed.

Reviewed PR #24 and fixed one incomplete part of the artifact cleanup: repo-hygiene/persona.json was still present as a generated persona file, so I removed it too.

Local checks run:

  • npm run typecheck passed
  • npm test passed
  • npm run compile passed and regenerated the ignored */persona.json outputs as expected; I cleaned those generated files back out afterward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant