Skip to content

test(review): require the channels subtree separator in the slack-scope guard #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jun 4, 2026
Merged

test(review): require the channels subtree separator in the slack-scope guard #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/review-agent.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ test('persona declares a slack scope that survives persona-kit parsing and cover
const scope = parsed?.slack?.scope;
assert.ok(scope && Object.keys(scope).length > 0, 'slack integration must declare a non-empty scope or cloud mounts no /slack paths');
const covers = Object.values(scope).some(
(value) => typeof value === 'string' && value.startsWith('/slack/channels'),
(value) => typeof value === 'string' && value.startsWith('/slack/channels/'),
);
assert.ok(covers, 'slack scope must cover /slack/channels/** so slackClient() drafts reach the writeback worker');
});