chore(deps): use published delivery package#90
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 41 minutes and 32 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 269cb1a57e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * set SLACK_CHANNEL, TELEGRAM_CHAT, or both — the handler delivers to | ||
| * whichever targets are configured. | ||
| * set SLACK_CHANNEL for Slack. To deploy with Telegram triggers/mounts too, | ||
| * set HN_MONITOR_ENABLE_TELEGRAM=1 during deploy and pass TELEGRAM_CHAT. |
There was a problem hiding this comment.
Require Telegram opt-in at compile time
With the repo’s documented flow of compiling persona.ts to persona.json and then deploying that JSON (README.md:9-10,41-42), this flag is consumed when the persona module is compiled, not just during deploy. If someone follows this comment and sets HN_MONITOR_ENABLE_TELEGRAM=1 only for the deploy step, the generated persona JSON has already omitted the Telegram integration and TELEGRAM_CHAT input, so the opt-in deployment will not have the Telegram mount/input it needs. Please require the flag for the persona compile step as well, or avoid deriving the persona shape from a transient env var.
Useful? React with 👍 / 👎.
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Review: PR #90 — fix(hn-monitor): make Telegram opt-inSummaryThis PR gates the hn-monitor's Telegram integration, trigger, and Verification
Pre-existing failures (NOT caused by this PR)
These stem from Addressed comments
Advisory Notes
OutcomeNo files were changed — the diff is a clean, well-tested config-gating change with passing hn-monitor tests and a clean typecheck. I did not edit anything: the PR logic is sound, the only |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Review: PR #90 —
|
Review of PR #90 —
|
Summary
Validation
Note
@agentworkforce/delivery@4.1.10 is now published and its package metadata depends on @agentworkforce/runtime 4.1.10 instead of workspace:*.
The remaining platform tradeoff: hn-monitor declares both Slack and Telegram integrations so runtime input selection can work after deploy. With current workforce deploy semantics, that means deploy preflight sees two integrations and will require both providers to be connected for a real cloud deploy. Avoiding that while keeping one persona would require conditional integration/trigger support in workforce.