Skip to content

ci(publish): refresh pnpm-lock.yaml during release bumps #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwashburn merged 1 commit into from
May 9, 2026
Merged

ci(publish): refresh pnpm-lock.yaml during release bumps #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,15 @@ jobs:
# Refresh Cargo.lock to reflect the new workspace version.
cargo update --workspace

# Refresh pnpm-lock.yaml so the workspace specifiers + optional
# platform dep versions match the bumped package.json files. Without
# this, the lock file lags one release behind every publish run
# (e.g. 2.7.0 ships, but the lock still pins 2.6.1 for
# `@relayburn/{cli,sdk}-<short>`), and the next `pnpm install
# --frozen-lockfile` on `main` fails. `--lockfile-only` skips
# node_modules churn — we already installed dependencies above.
pnpm install --lockfile-only

@chatgpt-codex-connector chatgpt-codex-connector Bot May 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Avoid resolving unpublished platform packages from npm

Running pnpm install --lockfile-only immediately after bumping every package to RELEASE_VER can block all real releases: this workflow updates umbrella optionalDependencies to exact versions that are not published yet, and pnpm 10 defaults to linkWorkspacePackages: false, so non-workspace: specs are resolved from the registry rather than local workspace packages. Because the publish loop that would create those versions runs later, this step can fail before any package is published (the subsequent "Verify new versions are not yet published" step confirms that unpublished state is expected).

Useful? React with 👍 / 👎.


# Belt-and-suspenders alongside the precursor's heal: even if the
# local→npm baseline was in sync there, the computed release
# version might collide with an existing version (e.g. someone
Expand Down Expand Up @@ -783,6 +792,7 @@ jobs:
packages/relayburn/npm/*/package.json \
packages/sdk-node/npm/*/package.json \
CHANGELOG.md \
pnpm-lock.yaml \
Cargo.toml Cargo.lock \
crates/relayburn-cli/Cargo.toml crates/relayburn-sdk-node/Cargo.toml
if git diff --cached --quiet; then
Expand Down
80 changes: 40 additions & 40 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading