Skip to content

Fix NAPI release SDK dependency lockstep#465

Merged
willwashburn merged 1 commit into
mainfrom
codex/fix-napi-release-lockstep
May 26, 2026
Merged

Fix NAPI release SDK dependency lockstep#465
willwashburn merged 1 commit into
mainfrom
codex/fix-napi-release-lockstep

Conversation

@willwashburn

Copy link
Copy Markdown
Member

Summary

  • update napi-build release lockstep to rewrite both Rust crates that path-depend on relayburn-sdk
  • keep napi-build aligned with publish.yml and cli-build.yml so cargo metadata resolves at major version bumps

Verification

  • simulated release_version=3.0.0 and ran cargo metadata --format-version 1 --manifest-path crates/relayburn-sdk-node/Cargo.toml --no-deps
  • cargo metadata --format-version 1 --manifest-path crates/relayburn-sdk-node/Cargo.toml --no-deps
  • cargo check -p relayburn-sdk-node

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9407263e-a8a6-41dd-97ba-97a4b362ff44

📥 Commits

Reviewing files that changed from the base of the PR and between 759cb1f and 6a093ef.

📒 Files selected for processing (1)
  • .github/workflows/napi-build.yml

📝 Walkthrough

Walkthrough

The napi-build.yml workflow's release-version pinning step now applies the lockstep version constraint to both relayburn-cli and relayburn-sdk-node Cargo manifests. The comment is updated to reflect this broader scope, the sed invocation becomes a loop covering both crates, and backup file cleanup extends to all affected manifests.

Changes

Workflow release version pinning

Layer / File(s) Summary
Extend lockstep version pinning to multiple crates
.github/workflows/napi-build.yml
The step comment is clarified to indicate multiple crates depend on relayburn-sdk. A single sed invocation becomes a loop that pins relayburn-sdk dependency versions in both relayburn-cli and relayburn-sdk-node using the input release_version. Backup file cleanup extends to remove .bak files for the root and both affected crate manifests.

Possibly related PRs

  • AgentWorkforce/burn#368: Introduced the initial lockstep release_version pinning step in napi-build.yml that this PR extends to additional workspace crates.
  • AgentWorkforce/burn#304: Modifies the same Cargo manifest dependency version fields for internal workspace crates, adding explicit version constraints on path dependencies.
  • AgentWorkforce/burn#353: Updates similar lockstep logic in publish.yml to pin relayburn-sdk dependency versions in the same crates.

Poem

A workflow grows a loop so neat,
To pin two crates in lockstep beat,
No single manifests stand alone,
But in cohesion, side by side they're known. 🐰
Release versions march in step and time,
This minor pinning—oh, so sublime!


🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix NAPI release SDK dependency lockstep' clearly describes the main change: fixing the NAPI build release process to properly synchronize SDK dependency versions across multiple crates.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose (updating napi-build to rewrite both Rust crates that depend on relayburn-sdk), the alignment goal, and verification steps performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-napi-release-lockstep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@willwashburn willwashburn merged commit b080424 into main May 26, 2026
8 checks passed
@willwashburn willwashburn deleted the codex/fix-napi-release-lockstep branch May 26, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant