Skip to content

ci: enforce rustfmt and clippy; add pnpm verify script#473

Merged
willwashburn merged 3 commits into
mainfrom
advisor/001-ci-quality-gates
Jun 10, 2026
Merged

ci: enforce rustfmt and clippy; add pnpm verify script#473
willwashburn merged 3 commits into
mainfrom
advisor/001-ci-quality-gates

Conversation

@willwashburn

Copy link
Copy Markdown
Member

Summary

CI has installed the rustfmt and clippy components since the beginning but never ran them, so drift accumulates until a bulk cleanup (#463 was the last one — and the tree had drifted again since). This PR ends the cycle:

  • Fixes the current rustfmt drift (one file, orchestration_tests.rs, line-wrapping only) as its own commit.
  • Adds two CI steps to the cargo-build-and-test job, placed after the build so clippy reuses the build cache: cargo fmt --all -- --check and cargo clippy --workspace --all-targets -- -D warnings (clippy is currently clean — zero warnings — so the gate starts green).
  • Adds pnpm run verify to the root package.json: fmt check → clippy → cargo test --workspacepnpm -r --if-present run buildpnpm run test. The npm build step matters: @relayburn/mcp tests run from dist/, and without a prior build the suite silently reports # tests 0 while exiting 0.
  • One README line documenting the verify command.

Verification

  • pnpm run verify exits 0 end-to-end: fmt clean, clippy zero warnings, full Rust workspace green, MCP suite executes 21/21 tests (was silently 0 before the build step was included).
  • Diff touches exactly 4 files; the only source change is fmt line-wrapping.

Plan: plans/001-ci-quality-gates.md (advisor-generated, executor-implemented, independently reviewed).

🤖 Generated with Claude Code

willwashburn and others added 2 commits June 10, 2026 11:00
Two method-chain splits in orchestration_tests.rs — whitespace/wrapping
only, no semantic change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Add `Check formatting` (cargo fmt --all -- --check) and `Clippy`
  (cargo clippy -D warnings) steps to the cargo-build-and-test job,
  after the build step to reuse the cache.
- Add `pnpm run verify` script to root package.json as a single gate
  that runs every check CI runs, including the npm wrapper build so
  the @relayburn/mcp dist/ tests actually execute.
- Document `pnpm run verify` in README.md Development section.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@willwashburn, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 78bca401-2d16-4137-8ca0-3ec0473224d8

📥 Commits

Reviewing files that changed from the base of the PR and between a350920 and 9765f22.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • README.md
  • crates/relayburn-sdk/src/ingest/orchestration_tests.rs
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch advisor/001-ci-quality-gates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@willwashburn willwashburn merged commit 6e29a1f into main Jun 10, 2026
11 checks passed
@willwashburn willwashburn deleted the advisor/001-ci-quality-gates branch June 10, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant