ci: enforce rustfmt and clippy; add pnpm verify script#473
Conversation
Two method-chain splits in orchestration_tests.rs — whitespace/wrapping only, no semantic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Add `Check formatting` (cargo fmt --all -- --check) and `Clippy` (cargo clippy -D warnings) steps to the cargo-build-and-test job, after the build step to reuse the cache. - Add `pnpm run verify` script to root package.json as a single gate that runs every check CI runs, including the npm wrapper build so the @relayburn/mcp dist/ tests actually execute. - Document `pnpm run verify` in README.md Development section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 17 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
CI has installed the rustfmt and clippy components since the beginning but never ran them, so drift accumulates until a bulk cleanup (#463 was the last one — and the tree had drifted again since). This PR ends the cycle:
orchestration_tests.rs, line-wrapping only) as its own commit.cargo-build-and-testjob, placed after the build so clippy reuses the build cache:cargo fmt --all -- --checkandcargo clippy --workspace --all-targets -- -D warnings(clippy is currently clean — zero warnings — so the gate starts green).pnpm run verifyto the root package.json: fmt check → clippy →cargo test --workspace→pnpm -r --if-present run build→pnpm run test. The npm build step matters:@relayburn/mcptests run fromdist/, and without a prior build the suite silently reports# tests 0while exiting 0.Verification
pnpm run verifyexits 0 end-to-end: fmt clean, clippy zero warnings, full Rust workspace green, MCP suite executes 21/21 tests (was silently 0 before the build step was included).Plan:
plans/001-ci-quality-gates.md(advisor-generated, executor-implemented, independently reviewed).🤖 Generated with Claude Code