Fix relayfile mount binary install publish#128
Conversation
Pulls @agentworkforce/runtime@3.0.50, which wires the Relay MCP server into cloud personas for both Claude and Codex harnesses (workforce #205). The lockfile previously pinned the whole agentworkforce family to 3.0.42, so `npm ci` installed a runtime without the relay-broker MCP wiring. Bump the two direct deps (agentworkforce, @agentworkforce/deploy) and regenerate the lock so the family resolves to 3.0.50. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. |
|
Warning Review limit reached
More reviews will be available in 40 minutes and 26 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpgrades ChangesAgentWorkforce version upgrade and install robustness
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various @AgentWorkforce packages to version 3.0.50 and refactors the relayfile-mount installation script to use a shared helper for atomic file replacement. It also introduces a new test suite for the installation script. The review feedback suggests improving the robustness of these tests on Windows by skipping the symlink test due to permission requirements and expanding the error-matching regex to handle Windows-specific filesystem errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }) | ||
| } | ||
|
|
||
| test('installFromFile replaces the target instead of copying through an existing symlink', async () => { |
There was a problem hiding this comment.
On Windows, creating symbolic links using fs.promises.symlink requires administrator privileges or Developer Mode enabled. In environments where these are not available (such as standard Windows CI runners or local non-admin developer setups), this test will fail with an EPERM error.\n\nTo ensure the test suite runs reliably across all platforms, consider skipping this specific test on Windows.
| test('installFromFile replaces the target instead of copying through an existing symlink', async () => { | |
| test('installFromFile replaces the target instead of copying through an existing symlink', { skip: process.platform === 'win32' ? 'Symlinks on Windows require admin privileges' : false }, async () => { |
| await writeFile(source, 'new-binary\n') | ||
| await mkdir(target, { recursive: true }) | ||
|
|
||
| await assert.rejects(runInstall(repoRoot, source), /EISDIR|ENOTDIR|directory/) |
There was a problem hiding this comment.
On Windows, attempting to rename a file to an existing directory typically throws an EPERM or EACCES error (e.g., EPERM: operation not permitted, rename ...) rather than EISDIR or ENOTDIR. The current assertion regex /EISDIR|ENOTDIR|directory/ will fail to match these Windows-specific error codes, causing the test to fail on Windows.\n\nExpanding the regex to include EPERM and EACCES will make the test robust and cross-platform.
| await assert.rejects(runInstall(repoRoot, source), /EISDIR|ENOTDIR|directory/) | |
| await assert.rejects(runInstall(repoRoot, source), /EISDIR|ENOTDIR|EPERM|EACCES|directory/) |
|
CodeAnt AI finished reviewing your PR. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Fixed the validated bot findings in relayfile-mount-install-script.test.ts:
Validation run locally:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the validated bot findings in relayfile-mount-install-script.test.ts:
Validation run locally:
|
|
Reviewed PR #128 against the current checkout. I didn’t find any remaining breakage to fix; the prior bot findings are already addressed in the checked-out code. Validation run locally:
|
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the current checkout. I didn’t find any remaining breakage to fix; the prior bot findings are already addressed in the checked-out code. Validation run locally:
|
|
Reviewed PR #128 against the current checkout. The bot findings from cubic were already addressed: Windows symlink skip is present, and the rename failure regex includes Local validation completed:
No additional fixes were needed. Note: initial |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the current checkout. The bot findings from cubic were already addressed: Windows symlink skip is present, and the rename failure regex includes Local validation completed:
No additional fixes were needed. Note: initial |
|
Reviewed PR #128 and made one scoped fix in the relayfile mount installer. Changed:
Validated:
|
|
✅ pr-reviewer applied fixes — committed and pushed Reviewed PR #128 and made one scoped fix in the relayfile mount installer. Changed:
Validated:
|
|
Fixed the remaining reproducible issue from the PR review thread: Checked the GitHub PR conversation for bot findings: the Windows symlink skip and Windows rename error regex were already present, and the later symlink-to-source finding was validated and fixed here. Local validation completed:
|
|
Fixed the remaining reproducible issue from the PR review thread: Checked the GitHub PR conversation for bot findings: the Windows symlink skip and Windows rename error regex were already present, and the later symlink-to-source finding was validated and fixed here. Local validation completed:
|
|
Reviewed PR #128 against the current checkout and PR conversation. I found no remaining reproducible breakage to fix. Validated locally:
Checked bot comments: the Windows symlink skip and rename error regex findings are already present in the current code, and the symlink-to-source installer issue is already fixed and covered by tests. |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the current checkout and PR conversation. I found no remaining reproducible breakage to fix. Validated locally:
Checked bot comments: the Windows symlink skip and rename error regex findings are already present in the current code, and the symlink-to-source installer issue is already fixed and covered by tests. |
|
Reviewed PR #128 against the checked-out diff and traced the changed installer, dependency bump, and broker CLI version path. I did not find a reproducible breakage in the current checkout, so I left the PR code unchanged. Validated locally:
No separate bot-review files were present under |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the checked-out diff and traced the changed installer, dependency bump, and broker CLI version path. I did not find a reproducible breakage in the current checkout, so I left the PR code unchanged. Validated locally:
No separate bot-review files were present under |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the current checkout. I did not find a reproducible breakage requiring code changes, so I left the PR source as-is and cleaned up the local relayfile binary generated during build. Local validation run:
All passed locally. Build warnings were existing Vite chunking warnings, not failures. |
1 similar comment
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against the current checkout. I did not find a reproducible breakage requiring code changes, so I left the PR source as-is and cleaned up the local relayfile binary generated during build. Local validation run:
All passed locally. Build warnings were existing Vite chunking warnings, not failures. |
|
Reviewed PR #128 against No code changes were needed after validation. I found no stale generated MCP resources and no demonstrated breakage in the dependency bump, installer symlink replacement, or broker CLI version update. Local validation run:
Build emitted only existing Vite chunking warnings, not failures. |
|
Reviewed PR #128 against Validated locally:
Cleaned the generated |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Reviewed PR #128 against Validated locally:
Cleaned the generated |
2 participants
User description
Summary
Fixes #123.
Tests
CodeAnt-AI Description
Enable Relay MCP support in cloud personas and harden relayfile-mount installs
What Changed
Impact
✅ Relay MCP available in cloud personas✅ Fewer broken relayfile-mount installs✅ Cleaner failed installs without leftover temp files💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.