Skip to content

Add workforce deploy dependency#13

Merged
khaliqgant merged 1 commit into
mainfrom
codex/add-workforce-deploy-dependency
May 21, 2026
Merged

Add workforce deploy dependency#13
khaliqgant merged 1 commit into
mainfrom
codex/add-workforce-deploy-dependency

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Summary

  • Add the published @agentworkforce/deploy@^3.0.15 package required by src/main/proactive-agent.bundle.ts.
  • Update package-lock.json with deploy/runtime/persona-kit and transitive runtime dependencies.

Why

Merged main imports @agentworkforce/deploy but does not declare it, so npm run build and npm run dev fail during main-process bundling before Electron starts.

Verification

  • npm install @agentworkforce/deploy@3.0.15
  • npm run build passes.
  • npm run dev passes main/preload bundling and starts Electron. Stopping the dev session still reports an existing unrelated shutdownAppOnce is not defined warning from src/main/index.ts.

Notes

../workforce current origin/main already has @agentworkforce/deploy@3.0.15, and npm has that version published with concrete dependencies. No workforce source change is required for this unblock; Pear only needed to declare the dependency it imports.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@khaliqgant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 37 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 26fd7bfa-7012-4da3-9757-7eba026cd652

📥 Commits

Reviewing files that changed from the base of the PR and between e74c264 and b655bb1.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@khaliqgant khaliqgant merged commit edf88e9 into main May 21, 2026
3 checks passed
miyaontherelay added a commit that referenced this pull request Jun 8, 2026
…lush

Fix #1/#13: initIfReady schedules a requestAnimationFrame retry when the
container has no layout (hidden tab, split page mounted at display:none).
mount() now always invokes initIfReady regardless of prior parentage so
the retry actually fires once the container becomes visible.

Fix #6: dispose() cancels the init rAF and calls clearPtyBuffer(key)
before flipping the disposed flag, so a queued rAF flush can't write
into a torn-down xterm. writeFromBuffer also early-returns when disposed
as belt-and-braces.
miyaontherelay added a commit that referenced this pull request Jun 8, 2026
…lush

Fix #1/#13: initIfReady schedules a requestAnimationFrame retry when the
container has no layout (hidden tab, split page mounted at display:none).
mount() now always invokes initIfReady regardless of prior parentage so
the retry actually fires once the container becomes visible.

Fix #6: dispose() cancels the init rAF and calls clearPtyBuffer(key)
before flipping the disposed flag, so a queued rAF flush can't write
into a torn-down xterm. writeFromBuffer also early-returns when disposed
as belt-and-braces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant