Fix git status startup spawn failures#15
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request refactors Git command execution from ChangesGit Operations Reliability and Performance
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
f0ea038 to
5011dfe
Compare
Fix #9: track last-sent rows/cols and skip duplicate resizePty IPC. The ResizeObserver fires on every dragged pixel; the cell grid only changes at discrete steps. Fix #12: refuse a second concurrent mount of the same runtime into a different container. Currently chunkAgents doesn't trigger this, but silently reparenting would tear xterm out from under the original owner. Fix #15: post-font-settle metrics may differ from the pre-settle ones the predictor was built with. Call predictiveEcho.onResize after the refit so column wraps line up with the real grid. Also adds refreshOnShow() and setInputSrttGetter() to the runtime interface in preparation for use-terminal wiring.
Summary
execFile-based git reads with a sharedspawnrunner that controls stdio explicitlygit:statusfailures in the IPC handler and return an empty status after a single warning instead of repeatedly rejecting during startup pollinggit diff --no-indexprocess per untracked fileVerification
npm run buildon the clean PR branchnpm run buildnpm run typecheckgit diff --no-indexchild flood, and no repeatedgit:statusspawn EBADFhandler errors observedNotes
npm run typecheckis not defined on current clean mainnpx tsc -b --noEmiton clean main still fails on pre-existing type drift in cloud/proactive/store/index/DiffPane/GraphView/syntax-highlighter files`