Skip to content

chore: populate terminal-renderer persona skills#165

Closed
miyaontherelay wants to merge 1 commit into
mainfrom
chore/terminal-renderer-skills
Closed

chore: populate terminal-renderer persona skills#165
miyaontherelay wants to merge 1 commit into
mainfrom
chore/terminal-renderer-skills

Conversation

@miyaontherelay

Copy link
Copy Markdown
Contributor

Extracts six discrete skills from the terminal-renderer persona's inline operating knowledge into the skills array, indexing the persona's expertise instead of leaving it all in claudeMdContent.

Skills added

  1. xterm-internals-and-renderers — parser pipeline, renderer types (DOM/Canvas/WebGL trade-offs), addon lifecycle, alt-screen, focus mode (DECSET ?1004), viewport vs scrollback.
  2. pty-broker-streaming-pipeline — rAF coalescing, snapshot-vs-replay race during attach, SIGWINCH semantics (the Ink TUI bounce case), trim cap accounting, broker-pty-chunk vs broker-event channels.
  3. ansi-vt-escape-sequences — CSI cursor movement, DECSET modes (?1004 focus, ?1049 alt screen, ?2004 bracketed paste, ?2026 sync output), OSC/DCS, redraw-in-place vs alt-screen vs synchronized TUI patterns.
  4. renderer-bug-class-triage — symptom-to-bug-class mapping from the live PR perf: UI smoothness pass — terminal + chat + styles #158 bug catalogue (snapshot-replay race, listener leak, font race, transform ghost frames, focus event redraw stacks, etc.).
  5. react-lifecycle-decoupling-and-token-ownership — module-level runtime registry, token-based mount ownership for cross-tree React commit ordering, clearOnDataIf identity check.
  6. fix-discipline-and-instrumentation — read-before-guessing, one-write-per-chunk invariant, minimal-diff scope, instrument-don't-guess after two failed fixes (PEAR_DIAG_PTY localStorage gate), AGENTS.md regression-test requirement.

Source namespace

Skills use @pear/persona-terminal-renderer/* as the source field, reserving logical package names if these get extracted to real npm packages later — matching the pattern in @agentworkforce/persona-autonomous-actor which uses real package sources.

Why now

PR #158's six-hour fix cycle taught the persona a lot. Capturing that as structured skills (rather than leaving it only in claudeMdContent) makes the expertise indexable and gives future personas a reference shape.

🤖 Generated with Claude Code

…ting knowledge

The persona had an empty skills array with all the operating knowledge
inline in claudeMdContent. Extract six discrete skills as a structured
index of the persona's expertise:

1. xterm-internals-and-renderers — parser pipeline, renderer types,
   addon lifecycle, alt-screen, focus mode, viewport vs scrollback
2. pty-broker-streaming-pipeline — rAF coalescing, snapshot-vs-replay
   race, SIGWINCH semantics, trim cap accounting
3. ansi-vt-escape-sequences — CSI cursor movement, DECSET modes
   (?1004 focus, ?1049 alt screen, ?2026 sync output), OSC/DCS, TUI
   redraw patterns
4. renderer-bug-class-triage — symptom-to-bug-class mapping from the
   live PR #158 catalogue
5. react-lifecycle-decoupling-and-token-ownership — module-level
   runtime registry, token-based mount, clearOnDataIf identity check
6. fix-discipline-and-instrumentation — read-before-guessing, one-write
   invariant, instrument-don't-guess after two failed fixes,
   AGENTS.md regression-test requirement

Source namespace `@pear/persona-terminal-renderer/*` reserves logical
package names if these skills get extracted to real packages later.
Pattern matches @agentworkforce/persona-autonomous-actor which uses
real packages for its skills.
@codeant-ai

codeant-ai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@miyaontherelay, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 19 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5035c109-20e8-49b9-9021-b8881bed1281

📥 Commits

Reviewing files that changed from the base of the PR and between 7b8e1b5 and 6a8d2ff.

📒 Files selected for processing (1)
  • .agentworkforce/workforce/personas/terminal-renderer.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/terminal-renderer-skills

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the terminal-renderer.json persona file by populating the skills array with detailed technical competencies. These competencies cover xterm.js internals, PTY broker streaming pipelines, ANSI/VT escape sequences, renderer bug triage, React lifecycle decoupling, and fix discipline. There are no review comments on these changes, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@miyaontherelay

Copy link
Copy Markdown
Contributor Author

Superseded by #168 which uses local skill files in __assets/terminal-renderer/ instead of phantom remote package source references. Matches the existing .agentworkforce asset pattern.

@miyaontherelay miyaontherelay deleted the chore/terminal-renderer-skills branch June 8, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant