Skip to content

fix(integration-events): add missing eventsSelfEchoSuppressed to mock telemetry (unbreak tsc)#182

Merged
kjgbot merged 1 commit into
mainfrom
fix/integration-telemetry-tsc-eventsselfechosuppressed
Jun 9, 2026
Merged

fix(integration-events): add missing eventsSelfEchoSuppressed to mock telemetry (unbreak tsc)#182
kjgbot merged 1 commit into
mainfrom
fix/integration-telemetry-tsc-eventsselfechosuppressed

Conversation

@kjgbot

@kjgbot kjgbot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Problem

tsc -p tsconfig.web.json fails on main (TS2741) in ipc-mock.ts: eventsSelfEchoSuppressed is required by IntegrationEventTelemetryCounters but missing from the mock telemetry totals object.

Cause

#177 (integration-event self-echo suppression) added eventsSelfEchoSuppressed to IntegrationEventCounterName but did not update the renderer mock telemetry object. The break has been on main since 1a5bd5d.

Fix

Add eventsSelfEchoSuppressed: 0 to the mock totals (the only counters object in ipc-mock.ts; projects is empty). tsc --noEmit -p tsconfig.web.json is clean after.

Unblocks tsc for everyone, including rebases of #172 / #176.

🤖 Generated with Claude Code

… telemetry

#177 added eventsSelfEchoSuppressed to IntegrationEventCounterName but the
ipc-mock telemetry totals object was not updated, breaking `tsc -p
tsconfig.web.json` on main (TS2741). Add the field (default 0) to the mock.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codeant-ai

codeant-ai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4889aced-0949-440b-b231-b2f7124ea609

📥 Commits

Reviewing files that changed from the base of the PR and between c371ce7 and d1d0649.

📒 Files selected for processing (1)
  • src/renderer/src/lib/ipc-mock.ts

📝 Walkthrough

Walkthrough

Updated the mock telemetry snapshot to include the eventsSelfEchoSuppressed counter field in the totals object, initialized to 0. This change aligns the mock return value with the expected telemetry schema.

Changes

Mock Telemetry Update

Layer / File(s) Summary
Telemetry snapshot totals extension
src/renderer/src/lib/ipc-mock.ts
The pearMock.integrations.telemetry mock returns a telemetry snapshot whose totals object now includes eventsSelfEchoSuppressed set to 0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A counter so small, suppressed with care,
In the telemetry mock, it sits fair,
Zero events echo, the field now complete,
The snapshot's totals are finally neat! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding the missing eventsSelfEchoSuppressed field to mock telemetry to fix TypeScript compilation errors.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (missing field), cause (PR #177), fix (adding the field), and impact (unblocking tsc and PR rebases).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/integration-telemetry-tsc-eventsselfechosuppressed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mock telemetry totals in ipc-mock.ts to include the eventsSelfEchoSuppressed field, initializing it to 0. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@kjgbot kjgbot merged commit 61345f0 into main Jun 9, 2026
4 checks passed
@kjgbot kjgbot deleted the fix/integration-telemetry-tsc-eventsselfechosuppressed branch June 9, 2026 08:34
@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed.

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

@agent-relay-code

Copy link
Copy Markdown
Contributor

pr-reviewer could not complete review for #182 in AgentWorkforce/pear.
The review harness exited with code 1.
No review was posted; this needs operator attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant