Skip to content

chore: bump agentworkforce to ^4.0.2 and refresh installed personas#224

Merged
khaliqgant merged 2 commits into
mainfrom
fix/persona-spawn-fail-fast
Jun 11, 2026
Merged

chore: bump agentworkforce to ^4.0.2 and refresh installed personas#224
khaliqgant merged 2 commits into
mainfrom
fix/persona-spawn-fail-fast

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Follow-up to #223, now that workforce 4.0.2 is published with the persona loader fix (AgentWorkforce/workforce#226) and the installer skill-asset support.

  • Bump agentworkforce + @agentworkforce/deploy ^3.0.51^4.0.2 (explicit major bump; caret on 3.x never picks up 4.x). Both the broker's resolveAgentWorkforceCommand and the personas:refresh npx script prefer the local install, so this is what switches the actual spawn path to the fixed CLI.
  • Update the AGENTWORKFORCE_CLI_VERSION npx-fallback pin in src/main/broker.ts to match, so machines without a local/global binary also get 4.0.2.
  • Re-ran personas:refresh with the 4.0.2 installer. It reproduced the hand-repaired linear-dispatcher.json / repo-router.json from fix(broker): fail fast when a persona worker exits before harness-ready; repair installed persona skill paths #223 byte-for-byte (validating the repair), and picked up the now-published permissions field in slack-comms.json. personas:refresh is safe to run again from here on.

Verification

  • agentworkforce show linear-dispatcher|repo-router --json from the repo root now resolves local skill sources to absolute paths that exist on disk (the 4.0.2 loader fix in action).
  • npm run typecheck:node clean; npm test 120/120.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@agent-relay-code[bot], we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af852da2-10a6-450f-b0c6-1f38b4e56e07

📥 Commits

Reviewing files that changed from the base of the PR and between af3027e and f4c79ba.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • .agentworkforce/workforce/personas/slack-comms.json
  • electron-builder.mcp-resources.yml
  • package.json
  • src/main/broker.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/persona-spawn-fail-fast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The 4.0.2 release carries the workforce-side fixes this branch depends
on: the persona loader resolves local skill sources against the persona
JSON's directory (AgentWorkforce/workforce#226), and the installer
copies local skill assets into __assets/ with rewritten sources.

- bump agentworkforce + @agentworkforce/deploy ^3.0.51 -> ^4.0.2
- update the AGENTWORKFORCE_CLI_VERSION npx fallback pin to match
- re-run personas:refresh with the 4.0.2 installer; it reproduced the
  hand-repaired linear-dispatcher/repo-router JSONs byte-for-byte and
  picked up the published slack-comms permissions field

Smoke-tested: `agentworkforce show` now resolves local skill sources to
absolute existing paths; typecheck and 120/120 tests pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@khaliqgant khaliqgant force-pushed the fix/persona-spawn-fail-fast branch from b7202be to 98ff1cd Compare June 11, 2026 10:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the linear-dispatcher and repo-router personas, updates the slack-comms persona, and upgrades the agentworkforce CLI dependencies to version 4.0.2. It also adds a liveness poll to the broker to handle premature persona exits, implements remote file writing capabilities in the integrations manager, and enhances the AttentionInbox UI with a 'Ready for Agent' band and a manual 'Spawn Team' feature. The feedback suggests removing a hardcoded local path in the dispatcher instructions, wrapping the detectRepo call in useMemo to optimize rendering performance, and expanding the REPO_KEYWORDS map to cover missing core repositories like cloud and agents.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

.agentworkforce/workforce/personas/__assets/linear-dispatcher/linear-dispatcher.md (59)

high

The repository path /Users/khaliqgant/Projects/AgentWorkforce/pear is hardcoded to a specific local user's directory. This will fail or be incorrect when run by other developers or in a CI/CD / cloud environment. Consider using a generic description or placeholder that can be dynamically resolved.

1. The repo path: the absolute path to the local clone of pear (or cloud/workforce as appropriate based on the issue label — cloud label → AgentWorkforce/cloud)

src/renderer/src/components/issues/AttentionInbox.tsx (174)

medium

To avoid redundant tokenization and keyword matching on every render of IssueOverviewCard, wrap the detectRepo call in useMemo.

  const detectedRepo = useMemo(() => {
    return issue.band === 'ready-for-agent' ? detectRepo(issue.title, issue.description) : null
  }, [issue.band, issue.title, issue.description])

src/renderer/src/lib/issue-scoping.ts (1-5)

medium

The REPO_KEYWORDS map is missing keywords for other core repositories in the ecosystem, such as cloud and agents (which are documented in agentworkforce-repo-map.md). Adding them will allow detectRepo to correctly route issues targeting the backend or agent harnesses.

const REPO_KEYWORDS: Record<string, string[]> = {
  relay: ['relay', 'agent-relay', 'broker', 'mcp', 'workspace', 'webhook', 'mount', 'relayfile'],
  pear: ['pear', 'electron', 'renderer', 'terminal', 'ui', 'inbox', 'sidebar', 'dialog', 'ipc'],
  workforce: ['workforce', 'persona', 'autonomous', 'proactive', 'agent-workforce', 'skill'],
  cloud: ['cloud', 'api', 'worker', 'nango', 'hono', 'd1', 'kv'],
  agents: ['agents', 'pr-reviewer', 'merge-on-green', 'harness']
}

@khaliqgant khaliqgant merged commit fad4222 into main Jun 11, 2026
5 checks passed
@khaliqgant khaliqgant deleted the fix/persona-spawn-fail-fast branch June 11, 2026 11:01
@agent-relay-code

Copy link
Copy Markdown
Contributor

No scoped PR breakage found, so I made no code edits. The changed MCP resource config is in sync with the generator, and the AgentWorkforce version bump is consistent across package.json, package-lock.json, and src/main/broker.ts.

Addressed Comments

  • coderabbitai[bot]: review was rate-limited and contained no actionable code finding. No change.
  • gemini-code-assist[bot]: hardcoded path in .agentworkforce/workforce/personas/__assets/linear-dispatcher/linear-dispatcher.md:59; valid in current checkout, but outside .workforce/pr.diff and outside this PR’s current scope. No change.
  • gemini-code-assist[bot]: suggested useMemo around detectRepo in src/renderer/src/components/issues/AttentionInbox.tsx:174; valid but outside .workforce/pr.diff and unrelated to this PR’s dependency/persona spawn change. No change.
  • gemini-code-assist[bot]: suggested expanding REPO_KEYWORDS in src/renderer/src/lib/issue-scoping.ts:1; valid but outside .workforce/pr.diff and unrelated to this PR’s current scope. No change.

Advisory Notes

Gemini’s three suggestions are reasonable follow-up cleanup items, but they should land in a separate PR that touches the dispatcher/inbox issue-scoping feature rather than this dependency/spawn-readiness PR.

Local Commands Run

  • npm ci
  • npm run verify:mcp-resources-drift
  • npm run lint passed with warnings only
  • npm run typecheck:web
  • npm run typecheck:node
  • npm test
  • npx vitest run
  • npm run build
  • npm run build:web
  • npx playwright install --with-deps chromium
  • npx playwright test --config playwright.fidelity.config.ts
  • npx playwright test --config playwright.redraw.config.ts

I could not run the macOS-only npm run dist:mac packaging smoke on this Linux host.

@agent-relay-code

Copy link
Copy Markdown
Contributor

No scoped PR breakage found, so I made no code edits. The package/resource updates are consistent, and the generated MCP resources remain in sync.

Addressed Comments

  • coderabbitai[bot]: review was rate-limited and contained no actionable code finding. No change.
  • gemini-code-assist[bot]: hardcoded local path in .agentworkforce/workforce/personas/__assets/linear-dispatcher/linear-dispatcher.md:59; valid in current checkout, but outside .workforce/pr.diff and unrelated to this PR’s current package/spawn update. No change.
  • gemini-code-assist[bot]: suggested useMemo around detectRepo in src/renderer/src/components/issues/AttentionInbox.tsx:174; valid but outside this PR’s scope. No change.
  • gemini-code-assist[bot]: suggested expanding REPO_KEYWORDS in src/renderer/src/lib/issue-scoping.ts:1; valid but outside this PR’s scope. No change.
  • agent-relay-code[bot]: prior summary comment reported no scoped breakage and no edits; revalidated against current checkout. No change.

Advisory Notes

Gemini’s three suggestions are reasonable follow-up cleanup items, but they belong in a separate issue-dispatch/inbox PR rather than this dependency/persona refresh PR.

Local Validation

Passed locally: npm ci, npm run verify:mcp-resources-drift, npm run lint with warnings only, npm run typecheck:web, npm run typecheck:node, npm test, npx vitest run, npm run build, npm run build:web, npx playwright test --config playwright.fidelity.config.ts, and npx playwright test --config playwright.redraw.config.ts.

I could not run the macOS-only npm run dist:mac packaging job on this Linux host. The GitHub PR page currently shows PR #224 as merged: #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant