Skip to content

Add cloud mount client and factory writeback guard#239

Merged
kjgbot merged 1 commit into
mainfrom
factory-sdk/w8-cloud-mount
Jun 11, 2026
Merged

Add cloud mount client and factory writeback guard#239
kjgbot merged 1 commit into
mainfrom
factory-sdk/w8-cloud-mount

Conversation

@kjgbot

@kjgbot kjgbot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add RelayfileCloudMountClient for direct cloud relayfile access to workspace rw_7ccfea89, with config-driven workspace/credentials and fake-client unit coverage.
  • Add default-on Linear writeback safety for setState, postComment, and createIssue.
  • Guard semantics: unwrap payload, allow only titles exactly [factory-e2e] or starting [factory-e2e] ; allow absent team; refuse present non-AR team; fail closed on unreadable/missing title.
  • Harden Linear parsing for sparse real sync shapes with missing labels, missing stateId, and state_name fallback.

Verification

  • npx vitest run packages/factory-sdk
  • npx tsc --noEmit -p tsconfig.node.json

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kjgbot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 18 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fa1fefc6-3d05-4f55-95ce-2e521ea8b0f8

📥 Commits

Reviewing files that changed from the base of the PR and between 3c8fe63 and 53eb366.

📒 Files selected for processing (12)
  • packages/factory-sdk/src/config/schema.test.ts
  • packages/factory-sdk/src/config/schema.ts
  • packages/factory-sdk/src/index.ts
  • packages/factory-sdk/src/mount/relayfile-cloud-mount-client.test.ts
  • packages/factory-sdk/src/mount/relayfile-cloud-mount-client.ts
  • packages/factory-sdk/src/orchestrator/factory.test.ts
  • packages/factory-sdk/src/orchestrator/factory.ts
  • packages/factory-sdk/src/ports/writeback.ts
  • packages/factory-sdk/src/testing/fakes.ts
  • packages/factory-sdk/src/writeback/index.ts
  • packages/factory-sdk/src/writeback/linear.ts
  • packages/factory-sdk/src/writeback/writeback.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch factory-sdk/w8-cloud-mount

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kjgbot kjgbot merged commit 81d08fb into main Jun 11, 2026
5 checks passed
@kjgbot kjgbot deleted the factory-sdk/w8-cloud-mount branch June 11, 2026 22:01
@agent-relay-code

Copy link
Copy Markdown
Contributor

Implemented a real fix in the PR scope: MountLinearWriteback.setState now preserves the existing Linear issue wrapper/payload and updates only payload.stateId before writing to Relayfile. This avoids clobbering cloud-mounted Linear issue records. The fake mount now uses replacement semantics so tests no longer hide partial-write bugs.

Changed:

Addressed comments

  • gemini-code-assist[bot]: quota-limit warning only; no actionable code finding.
  • coderabbitai[bot]: review-rate-limit/usage warning only; no actionable code finding.

Advisory Notes

  • GitHub connector status for head 53eb366 only exposed CodeRabbit: success; it did not expose full Actions/mergeability state, so I am not printing READY.

Local checks run:

  • npm ci
  • npm run verify:mcp-resources-drift
  • npm run lint (warnings only)
  • npm run typecheck:web
  • npm run typecheck:node
  • npm test
  • npx vitest run
  • npm run build
  • npm run build:web
  • npx playwright install chromium
  • npx playwright test --config playwright.fidelity.config.ts
  • npx playwright test --config playwright.redraw.config.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant