Submit confirmed factory task injections#255
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 20 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Implemented one scoped fix in the PR retry path. Changed factory.ts so a failed critical message id is consumed before retrying. This prevents a replayed duplicate Added a regression test in factory.test.ts that emits the same Addressed comments
Advisory NotesNone. Local validation passed after the edit:
I’m not printing |
Summary
FleetClient.sendInput(name, data)and wiresInternalFleetClientthrough to the harness driver's raw PTY input API.'\r'after every confirmed factorywaitForInjectedack, including implementer task injects, reviewer queued-message injects, and delivery-failure re-inject retries.Validation
npx vitest run packages/factory-sdk/src/orchestrator/factory.test.ts packages/factory-sdk/src/fleet/internal-fleet-client.test.ts-> 84 passednpx vitest run packages/factory-sdk && npx tsc --noEmit -p tsconfig.node.json-> 228 passed, tsc 0Notes
waitForInjected(...)resolving beforesendInput(target, '\r'); V0 pins that order.'\r'against the codex PTY snapshot oracle.