Skip to content

AR-236: add square utility#278

Closed
kjgbot wants to merge 1 commit into
mainfrom
ar-236-square-util
Closed

AR-236: add square utility#278
kjgbot wants to merge 1 commit into
mainfrom
ar-236-square-util

Conversation

@kjgbot

@kjgbot kjgbot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a pure square(n) utility to factory-sdk
  • Add Vitest coverage for positive, negative, and zero inputs

Validation

  • npx vitest run packages/factory-sdk/src/square.test.ts

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kjgbot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 94023082-44bf-4c74-a253-4cf5a6640c5a

📥 Commits

Reviewing files that changed from the base of the PR and between de24cb3 and c414daa.

📒 Files selected for processing (2)
  • packages/factory-sdk/src/square.test.ts
  • packages/factory-sdk/src/square.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ar-236-square-util

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new square utility function and its corresponding unit tests. The feedback points out that the new utility is not exported from the SDK's main entry point (index.ts), which prevents external consumers from using it, and suggests adding the appropriate export statement.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@@ -0,0 +1,3 @@
export function square(n: number): number {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The square utility is defined here but is not exported from the SDK's main entry point (packages/factory-sdk/src/index.ts). To make this utility available to external consumers of the SDK, please add the export statement to index.ts:

export { square } from './square'

@kjgbot

kjgbot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Closing per factory close-never-merge policy: synthetic [factory-e2e] probe PR (issue is synthetic; probe PRs are close-never-merge by policy, never merged). Manual enforcement — the daemon's auto-close no-op'd because the PR title lacks the [factory-e2e] marker (close-probe bug, fix in flight).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant