[factory] p3: publishable build + bin rename (factory-sdk → @agent-relay/factory)#370
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughRenames Changesfactory-sdk Publish Preparation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69101c6f7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "declarationMap": true, | ||
| "sourceMap": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "Bundler", |
There was a problem hiding this comment.
Make the dist CLI Node-runnable
With moduleResolution: "Bundler" and plain tsc, the emitted ESM preserves extensionless relative imports from the sources, e.g. dist/cli/fleet.js imports ../mount/local-mount-preflight. The new bin/factory.mjs loads that file directly under Node ESM, which does not resolve extensionless relative specifiers, so the published factory command fails before parsing any args with ERR_MODULE_NOT_FOUND; use a Node-compatible emit or bundle/rewrite extensions before pointing the bin at dist.
Useful? React with 👍 / 👎.
| "./writeback": { "types": "./dist/writeback/index.d.ts", "import": "./dist/writeback/index.js" } | ||
| }, | ||
| "scripts": { "build": "tsc -p tsconfig.build.json", "test": "vitest run" }, | ||
| "devDependencies": { "esbuild": "^0.24.2" } |
There was a problem hiding this comment.
Declare the package's runtime dependencies
Because this commit makes the package public and points exports/bin at dist, installs of @agent-relay/factory will only get dependencies declared in this manifest, but there is no dependencies section. The emitted entry points import runtime modules such as zod (src/config/schema.ts), @agent-relay/harness-driver (src/fleet/internal-fleet-client.ts), and @agent-relay/cloud/@relayfile/sdk (src/mount/relayfile-cloud-mount-client.ts), so the package only works inside the Pear repo where root dependencies are present and fails for npm consumers once those imports load.
Useful? React with 👍 / 👎.
Factory build-out p3 (publish-prep): tsc dist build, exports → dist, drop private, public access, bin rename. Spec: factory/planning/linear-issue-factory-extract-p3-publish-prep.md.
Built by the factory relayflows squad (commit 69101c6); the run wedged at the open-pr step on the relayflows broker-robustness bug (AgentWorkforce/relayflows issue below), so opening the PR manually. Branch was already committed + pushed.
🤖 Generated with Claude Code