Skip to content

fix(acp-bridge,openclaw): use AgentRelay.spawnAgent instead of removed spawnPty#1007

Merged
willwashburn merged 1 commit into
mainfrom
claude/peaceful-bell-RThev
May 27, 2026
Merged

fix(acp-bridge,openclaw): use AgentRelay.spawnAgent instead of removed spawnPty#1007
willwashburn merged 1 commit into
mainfrom
claude/peaceful-bell-RThev

Conversation

@willwashburn

Copy link
Copy Markdown
Member

Summary

Fixes the failing CI build on main (run 26520261748).

After PR #1003 / #1006, AgentRelay only exposes spawnAgentspawnPty lives only on AgentRelayClient. Two callers were still using relay.spawnPty(...) on AgentRelay instances, which broke the TypeScript build of @agent-relay/acp-bridge (the visible CI failure) and would have broken @agent-relay/openclaw next.

  • packages/acp-bridge/src/acp-agent.ts:739relay.spawnPty(...)relay.spawnAgent(...)
  • packages/openclaw/src/spawn/process.ts:174 — same

Test plan

  • npm run build is green locally (all 19 turbo tasks)
  • CI on this PR passes

https://claude.ai/code/session_0181Fs6YPkrKrGeRQk3YFqi1


Generated by Claude Code

…d spawnPty

The AgentRelay class no longer exposes spawnPty (it lives only on
AgentRelayClient). The two remaining callers were using the unified
spawnAgent facade was renamed during the #1003 spawn-provider work, so
this restores the build for both packages.
@willwashburn willwashburn requested a review from khaliqgant as a code owner May 27, 2026 15:31
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6902c155-2d7d-4018-93da-aaf2931e4dfd

📥 Commits

Reviewing files that changed from the base of the PR and between d4bc060 and f63b667.

📒 Files selected for processing (2)
  • packages/acp-bridge/src/acp-agent.ts
  • packages/openclaw/src/spawn/process.ts

📝 Walkthrough

Walkthrough

This PR switches two relay SDK spawn call sites from spawnPty to spawnAgent. In acp-bridge and openclaw/spawn, agent relay invocations now use spawnAgent with the same name, CLI, task, and configuration arguments, while maintaining existing readiness waits and error handling flows.

Changes

Spawn Method Migration

Layer / File(s) Summary
Spawn API migration across packages
packages/acp-bridge/src/acp-agent.ts, packages/openclaw/src/spawn/process.ts
Both handleSpawnCommand and ProcessSpawnProvider.spawn switch from relay.spawnPty(...) to relay.spawnAgent(...) while preserving identical arguments and surrounding spawn configuration logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

  • AgentWorkforce/relay#998: These changes align with the goal of adding and surfacing additional spawn methods on AgentRelay (spawnHeadless/spawnProvider/spawnAgent).

Possibly related PRs

  • AgentWorkforce/relay#846: Both PRs touch the CLI "spawn" command path and relay spawn invocation; the retrieved PR updates spawn mocks and scoping around the spawn call, while this PR switches the relay method being invoked.

Suggested reviewers

  • khaliqgant

Poem

🐰 A spawn call hops from pty to agent bright,
Two pathways sync with method new in sight,
No args confused, same config stays the same,
The relay dances to a different name! 🎭

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing removed spawnPty calls with spawnAgent across two packages.
Description check ✅ Passed The description covers the summary and test plan sections required by the template, providing context about the CI failure and specific changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/peaceful-bell-RThev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@willwashburn willwashburn merged commit b29b6a1 into main May 27, 2026
54 checks passed
@willwashburn willwashburn deleted the claude/peaceful-bell-RThev branch May 27, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants