Docs: refresh Agent Relay skill handoff#1087
Merged
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR modernizes Agent Relay skill documentation to align with ChangesAgent Relay Documentation Alignment with
Web UI Skill Page Refactoring and New Route Launch
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.claude/skills/writing-agent-relay-workflows/SKILL.md (1)
1060-1066:⚠️ Potential issue | 🟠 MajorFix/implement missing
pr_urlverification type support in the runner
pr_urlis mentioned only in.claude/skills/writing-agent-relay-workflows/SKILL.md/CHANGELOG.md, but repo code contains noverification.type: "pr_url"handling.- The SDK verification type union does not include it:
packages/sdk-py/src/agent_relay/types.pydefinesLiteral["output_contains", "exit_code", "file_exists", "custom"].- Broker-side “delivery verification” logic is echo-string based (
crates/broker/src/broker/delivery_verification.rs) and does not validate PR URLs.Either add real
pr_urlverification support to the workflow runner (including the documentedvaluesemantics) or remove it from the docs to avoid false “auto-pass” completion.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/skills/writing-agent-relay-workflows/SKILL.md around lines 1060 - 1066, The docs advertise a verification type "pr_url" but the codebase lacks support; update the SDK type union in packages/sdk-py/src/agent_relay/types.py to include Literal["pr_url"] (and the associated Pydantic model field `verification`/`value` semantics), implement broker-side validation in crates/broker/src/broker/delivery_verification.rs to recognize "pr_url" and verify output contains a valid GitHub PR URL and optional owner/repo match (enforce the documented `<owner>/<repo>` behaviour), and wire the runner/adapter that emits verification results so a deterministic PR-step prints the URL and is validated; if you prefer removing the feature, instead remove `pr_url` from SKILL.md/CHANGELOG.md and from the SDK union so docs and code stay consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.claude/skills/writing-agent-relay-workflows/SKILL.md:
- Around line 1060-1066: The docs advertise a verification type "pr_url" but the
codebase lacks support; update the SDK type union in
packages/sdk-py/src/agent_relay/types.py to include Literal["pr_url"] (and the
associated Pydantic model field `verification`/`value` semantics), implement
broker-side validation in crates/broker/src/broker/delivery_verification.rs to
recognize "pr_url" and verify output contains a valid GitHub PR URL and optional
owner/repo match (enforce the documented `<owner>/<repo>` behaviour), and wire
the runner/adapter that emits verification results so a deterministic PR-step
prints the URL and is validated; if you prefer removing the feature, instead
remove `pr_url` from SKILL.md/CHANGELOG.md and from the SDK union so docs and
code stay consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c9ebbde9-272f-4b25-9872-49b2cf0c94b0
📒 Files selected for processing (25)
.agents/skills/choosing-swarm-patterns/SKILL.md.agents/skills/relay-80-100-workflow/SKILL.md.agents/skills/using-agent-relay/SKILL.md.agents/skills/writing-agent-relay-workflows/SKILL.md.claude/skills/choosing-swarm-patterns/SKILL.md.claude/skills/relay-80-100-workflow/SKILL.md.claude/skills/using-agent-relay/SKILL.md.claude/skills/writing-agent-relay-workflows/SKILL.mdREADME.mdplugins/codex-relay-skill/SKILL.mdweb/app/landing.module.cssweb/app/openclaw/skill/invite/[token]/page.tsxweb/app/openclaw/skill/page.tsxweb/app/robots.tsweb/app/sitemap.tsweb/app/skill/page.tsxweb/components/SkillPage.tsxweb/components/home/Hero.tsxweb/components/home/QuickStart.tsxweb/content/agent-relay/SKILL.mdweb/content/openclaw/SKILL.mdweb/lib/site-analytics.tsweb/lib/skill-markdown.tsweb/lib/test/site-analytics.test.tsweb/lib/test/skill-markdown.test.ts
Added quick test and integration instructions for agents.
Contributor
|
Preview deployed!
This preview will be cleaned up when the PR is merged or closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
No changelog entry: docs and website skill handoff only.