Skip to content

chore: remove the deprecated @agent-relay/telemetry placeholder package#1181

Merged
willwashburn merged 2 commits into
mainfrom
chore/remove-deprecated-telemetry-package
Jun 21, 2026
Merged

chore: remove the deprecated @agent-relay/telemetry placeholder package#1181
willwashburn merged 2 commits into
mainfrom
chore/remove-deprecated-telemetry-package

Conversation

@willwashburn

@willwashburn willwashburn commented Jun 21, 2026

Copy link
Copy Markdown
Member

packages/telemetry was a private, deprecated placeholder (its package.json description: "Deprecated Agent Relay telemetry package placeholder"). Telemetry moved into the CLI at packages/cli/src/cli/telemetry. Nothing depends on it (0 lockfile dependents, no source imports) and it's not in any build chain — but its deprecated package.json field made npm ci print a deprecation warning on every install.

Changes

  • Delete the packages/telemetry workspace and prune its (extraneous) node from package-lock.json.
  • Remove the now-dangling references: the build:telemetry root script, the telemetry entry in package-validation SKIP_PACKAGES, the knip.json workspace entry, and the vitest.config.ts coverage exclude.
  • Repoint stale doc references to the current telemetry source (packages/cli/src/cli/telemetry): the broker telemetry.rs schema-mirror comment, the publish.yml posthog-config comment, and the web telemetry page's "inspect source" link.

Validation

  • npm install no longer emits the @agent-relay/telemetry deprecation warning; lockfile has zero references.
  • package.json / knip.json parse; vitest config loads and a suite runs.
  • The package was already deprecated/unused, so no behavior change.

Review in cubic

`packages/telemetry` was a private, deprecated placeholder (telemetry moved
into the `agent-relay` CLI under `packages/cli/src/cli/telemetry`). Nothing
depended on it or imported it, yet its `deprecated` package.json field made
`npm ci` print a deprecation warning on every install.

- Delete the `packages/telemetry` workspace and prune it from the lockfile.
- Drop the dangling `build:telemetry` root script, the `telemetry` entry in
  package-validation `SKIP_PACKAGES`, the `knip.json` workspace entry, and the
  `vitest.config.ts` coverage exclude.
- Repoint stale references to the current telemetry source: the broker
  `telemetry.rs` schema comment, the `publish.yml` posthog-config comment, and
  the web telemetry page's "inspect source" link now point at
  `packages/cli/src/cli/telemetry`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 09aec74a-96d1-453d-bc37-bc49dca11c2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The packages/telemetry standalone package is removed from the monorepo. Its build:telemetry root script, KNIP workspace config, vitest coverage exclusion, and deprecated package.json are deleted. CI package validation, the publish workflow comment, a Rust doc comment, and the web telemetry page link are all updated to reference packages/cli/src/cli/telemetry.

Changes

Telemetry Package Removal Cleanup

Layer / File(s) Summary
Remove telemetry from monorepo tooling and build config
package.json, knip.json, vitest.config.ts, packages/telemetry/package.json
Removes the build:telemetry npm script, the packages/telemetry KNIP workspace entry, and the packages/telemetry/** vitest coverage glob (replaced with specific packages/cloud/src/ exclusions); deletes the deprecated packages/telemetry/package.json.
Update CI validation and cross-repo references
.github/workflows/package-validation.yml, .github/workflows/publish.yml, crates/broker/src/telemetry.rs, web/app/telemetry/page.tsx
Removes telemetry from the CI dist-file skip list, corrects a publish workflow comment, updates a Rust schema-alignment doc comment, and changes the web telemetry page source link — all pointing to packages/cli/src/cli/telemetry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop, hop, the old path is gone,
No more packages/telemetry to build upon!
The CLI now holds that telemetry nest,
Comments and links all put to the test.
One little hop and the cleanup is done ~✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove the deprecated @agent-relay/telemetry placeholder package' clearly and specifically describes the main change—removing a deprecated placeholder package.
Description check ✅ Passed The description includes a detailed summary explaining the rationale, comprehensive list of changes, and validation steps, though it lacks explicit Test Plan checkboxes from the template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-deprecated-telemetry-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated @agent-relay/telemetry package and integrates telemetry internally within the CLI package, updating references, build scripts, and configurations across the repository. Feedback is provided regarding an extraneous dependency flag added to package-lock.json, which suggests regenerating the lockfile to ensure a clean state.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package-lock.json
},
"node_modules/@clack/prompts/node_modules/is-unicode-supported": {
"version": "1.3.0",
"extraneous": true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The 'extraneous': true property has been added to 'is-unicode-supported' in 'package-lock.json'. This usually indicates that the lockfile was generated while 'node_modules' was in an inconsistent or dirty state. To maintain lockfile hygiene and prevent potential installation issues in CI, please clean your local environment and regenerate the lockfile by running 'rm -rf node_modules package-lock.json && npm install'.

…ed-telemetry-package

# Conflicts:
#	package-lock.json
@github-actions

Copy link
Copy Markdown
Contributor

Preview deployed!

Environment URL
Web https://d32mrzm05uj62c.cloudfront.net

This preview will be cleaned up when the PR is merged or closed.

@willwashburn willwashburn merged commit ff3f773 into main Jun 21, 2026
45 checks passed
@willwashburn willwashburn deleted the chore/remove-deprecated-telemetry-package branch June 21, 2026 12:57
willwashburn added a commit that referenced this pull request Jun 21, 2026
* ci(publish): drop the removed @agent-relay/telemetry package

#1181 deleted the `packages/telemetry` placeholder, but the Publish Package
workflow still listed `telemetry` in two publish matrices, so the spawned job
failed at `cd packages/telemetry` ("No such file or directory"). Remove
`telemetry` from the publish-all and publish-main-runtime-deps matrices.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(trajectories): consolidate stray root .trajectories into canonical dir

A trajectory (`traj_o61z0ze6kvla`, "Review and fix PR #1092") was written to a
stray root `.trajectories/` instead of the canonical `.agentworkforce/relay`
data dir the tool now defaults to, so it never showed up in `trail list`.

Move it into `.agentworkforce/trajectories/completed/2026-06/` and drop the
empty root `.trajectories/`. Default `trail list` now counts it (257 -> 258);
`trail doctor` is clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant