Improve LogViewer mobile scrolling#161
Merged
Merged
Conversation
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 1 file reviewed • 1 high risk • 1 need attention
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
willwashburn
added a commit
that referenced
this pull request
Jun 9, 2026
Server-side telemetry on the relaycast backend recorded `harness: "unknown"` for 100% of events, even though the broker already detects the orchestrator harness (claude-code / codex / cursor / …) for its own PostHog events. The detected value was siloed in TelemetryClient and never forwarded to the relaycast SDK, so the `X-Relaycast-Harness` header (HTTP) and `?harness=` query (WS) were never sent and the backend defaulted to "unknown". Forwarding requires SDK >= 2.3.0 (`with_harness` was added in relaycast #161, published as 2.3.0). Bumping `=2.0.0` -> `=2.3.0` also pulls in the v8 event contract the gateway already emits, which is a net fix: the broker at 2.0.0 only recognized the pre-v8 `reaction.added` / `agent.online` event types, while the deployed gateway sends `message.reacted` / `agent.status.*` — so reactions and presence were being silently dropped. Changes: - Bump `relaycast` SDK `=2.0.0` -> `=2.3.0`. - Cache the detected harness in `telemetry::orchestrator_harness{,_opt}()` (process-tree detection walks parent PIDs; resolve once) and reuse it for both our PostHog events and the forwarded value. - Forward the harness at all three relaycast client sites: the WS handshake (`WsClientOptions::with_harness`) and both HTTP `build_relay_client` helpers (`RelayCastOptions::with_harness`). - Inject `AGENT_RELAY_HARNESS` into spawned-agent env via `spawn_env_vars` so JS-SDK agents (`@relaycast/sdk`, env-only harness resolution, no process-tree fallback) report it too. Threaded as a parameter for deterministic tests. - Update 3 stale bridge fixtures to the v8 event names the gateway emits (`message.reacted` with `action`, `agent.status.active`); fix `drops_reaction_without_channel` to exercise the no-channel drop rather than an unknown-type drop. Tests: 701 broker lib tests pass (+2 new harness env tests); clippy clean; fmt clean. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- allow touch scroll gestures to reach the xterm viewport on coarse pointers\n- avoid canvas intercepting scroll on mobile devices\n\n## Testing\n- not run