Skip to content

Fix LogViewer mobile scroll containment #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jan 14, 2026
Merged

Fix LogViewer mobile scroll containment #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/dashboard/react-components/LogViewerPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,21 @@ export function LogViewerPanel({
return () => window.removeEventListener('keydown', handleKeyDown);
}, [isOpen, onClose]);

// Prevent body scroll when fullscreen
// Prevent body scroll when panel is open (fix mobile scroll capture)
useEffect(() => {
if (isOpen && position === 'fullscreen') {
document.body.style.overflow = 'hidden';
return () => {
document.body.style.overflow = '';
};
}
}, [isOpen, position]);
if (!isOpen) return;

const previousOverflow = document.body.style.overflow;
const previousOverscroll = document.body.style.overscrollBehavior;

document.body.style.overflow = 'hidden';
document.body.style.overscrollBehavior = 'none';

return () => {
document.body.style.overflow = previousOverflow;
document.body.style.overscrollBehavior = previousOverscroll;
};
}, [isOpen]);

if (!isOpen) return null;

Expand Down Expand Up @@ -280,7 +286,7 @@ export function LogViewerPanel({
</div>

{/* Log viewer */}
<div className="flex-1 min-h-0">
<div className="flex-1 min-h-0 overflow-hidden">
<LogViewer
agentName={agent.name}
mode="panel"
Expand Down
23 changes: 13 additions & 10 deletions src/dashboard/react-components/XTermLogViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,17 +549,20 @@ export function XTermLogViewer({
</div>
)}

{/* Terminal container - don't use overflow-auto here, xterm-viewport handles scrolling */}
{/* Terminal container - keep a dedicated scroll boundary for mobile */}
<div
ref={containerRef}
className="flex-1 touch-pan-y"
style={{
maxHeight,
minHeight: '200px',
overscrollBehavior: 'contain',
touchAction: 'pan-y',
}}
/>
className="flex-1 min-h-0 overflow-hidden"
style={{ maxHeight, minHeight: '200px' }}
>
<div
ref={containerRef}
className="h-full w-full touch-pan-y"
style={{
overscrollBehavior: 'contain',
touchAction: 'pan-y',
}}
/>
</div>

{/* Footer status bar */}
<div
Expand Down
Loading