fix: Add cloud infrastructure for user message routing

[khaliqgant]

Summary

Completes the cross-machine user routing feature by adding missing cloud infrastructure. The previous daemon-side fix (PR #212, commit 41d7b4f) was correct but incomplete - the cloud server lacked the necessary components to actually discover and deliver messages to users.

Root Cause Analysis

Not a Regression - Missing Feature

Investigation via git log and git blame revealed this is not a regression:

Date	Commit	Description
Dec 30, 2025	ba37864	Cloud-daemon linking added - agents only
Jan 1, 2026	37996c0	Cross-machine integration completed - agents only
Jan 17, 2026	41d7b4f	First user routing fix - daemon-side only
Jan 18, 2026	126e1f8	This fix - cloud infrastructure

The original cross-machine routing (commits ba37864, 37996c0) was designed exclusively for agent-to-agent communication. User routing was never implemented:

1. /api/daemons/agents returned allAgents but never allUsers
2. No presence tracking accessible to API routes
3. No mechanism to deliver messages to cloud-connected users

Why First Fix (41d7b4f) Didn't Work

The daemon-side code was correct:

• Added isRemoteUser() method
• Router checks for remote users
• Cloud-sync expects allUsers from API

But the cloud server never returned allUsers because:

• onlineUsers Map was local to WebSocket handler in server.ts
• API routes in daemons.ts couldn't access it
• No message delivery mechanism for daemonId: 'cloud'

What This Fix Does

New Services

1. PresenceRegistry (src/cloud/services/presence-registry.ts)

   • Shared module for tracking online users
   • Accessible to both WebSocket handlers and API routes
   • Exports getOnlineUsersForDiscovery() in RemoteAgent format

2. CloudMessageBus (src/cloud/services/cloud-message-bus.ts)

   • Event-based pub/sub for message delivery
   • API routes publish, WebSocket handlers subscribe
   • Delivers messages to user's presence WebSocket connections

Updated Components

3. /api/daemons/agents endpoint - Now returns allUsers alongside allAgents

4. /api/daemons/message endpoint - Special handling for targetDaemonId === 'cloud'

5. server.ts - Registers/unregisters users with presence registry, subscribes to message bus

Message Flow

Agent → Daemon → POST /api/daemons/message (daemonId=cloud)
  → CloudMessageBus.sendToUser()
  → wssPresence WebSocket
  → User Dashboard

Test Coverage

Added 23 new tests:

• PresenceRegistry (17 tests): registration, unregistration, lastSeen updates, online status, discovery format
• CloudMessageBus (6 tests): event emission, metadata, multiple subscribers, independent delivery

Files Changed

• src/cloud/services/presence-registry.ts (new)
• src/cloud/services/cloud-message-bus.ts (new)
• src/cloud/services/presence-registry.test.ts (new)
• src/cloud/services/cloud-message-bus.test.ts (new)
• src/cloud/services/index.ts (exports)
• src/cloud/api/daemons.ts (allUsers + cloud routing)
• src/cloud/server.ts (presence registry + message bus)

Test Plan

• All existing tests pass (99 tests)
• New service tests pass (23 tests)
• TypeScript compiles without errors
• Manual test: Agent → User message delivery via cloud dashboard

🤖 Generated with Claude Code

[my-senior-dev-pr-review]

🤖 My Senior Dev — Analysis Complete

👤 For @khaliqgant

📁 Expert in src/dashboard/react-components/ (10 edits) • ⚡ 69th PR this month

View your contributor analytics →

---

📊 7 files reviewed • 3 high risk • 2 need attention

🚨 High Risk:

• src/cloud/api/daemons.ts — Contains critical message routing logic with potential security risks and performance issues.

⚠️ Needs Attention:

• src/cloud/api/daemons.ts — Critical for message handling and user tracking; concerns about performance under load need examination.

---

🚀 Open Interactive Review →

The full interface unlocks features not available in GitHub:

• 💬 AI Chat — Ask questions on any file, get context-aware answers
• 🔍 Smart Hovers — See symbol definitions and usage without leaving the diff
• 📚 Code Archeology — Understand how files evolved over time (/archeology)
• 🎯 Learning Insights — See how this PR compares to similar changes

---

💬 Chat here: @my-senior-dev explain this change — or try @chaos-monkey @security-auditor @optimizer @skeptic @junior-dev

📖 View all 12 personas & slash commands

You can interact with me by mentioning @my-senior-dev in any comment:

In PR comments or on any line of code:

• Ask questions about the code or PR
• Request explanations of specific changes
• Get suggestions for improvements

Slash commands:

• /help — Show all available commands
• /archeology — See the history and evolution of changed files
• /profile — Performance analysis and suggestions
• /expertise — Find who knows this code best
• /personas — List all available AI personas

AI Personas (mention to get their perspective):

Persona	Focus
@chaos-monkey 🐵	Edge cases & failure scenarios
@skeptic 🤨	Challenge assumptions
@optimizer ⚡	Performance & efficiency
@security-auditor 🔒	Security vulnerabilities
@accessibility-advocate ♿	Inclusive design
@junior-dev 🌱	Simple explanations
@tech-debt-collector 💳	Code quality & shortcuts
@ux-champion 🎨	User experience
@devops-engineer 🚀	Deployment & scaling
@documentation-nazi 📚	Documentation gaps
@legacy-whisperer 🏛️	Working with existing code
@test-driven-purist ✅	Testing & TDD

For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews.