Skip to content

Add proposal for train of thought trajectories#3

Merged
khaliqgant merged 8 commits into
mainfrom
claude/store-task-conversations-Js8Py
Dec 21, 2025
Merged

Add proposal for train of thought trajectories#3
khaliqgant merged 8 commits into
mainfrom
claude/store-task-conversations-Js8Py

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Design document for storing task conversations and agent reasoning
as first-class artifacts. Covers storage architecture, capture
mechanisms, retrospectives, and how trajectories help with code
review, bug diagnosis, and institutional memory.

Design document for storing task conversations and agent reasoning
as first-class artifacts. Covers storage architecture, capture
mechanisms, retrospectives, and how trajectories help with code
review, bug diagnosis, and institutional memory.
- Add TaskReference abstraction (works with Beads, Linear, Jira, GitHub, or standalone)
- Define universal .trajectory file format (JSON primary, Markdown generated)
- Add TaskSourceAdapter interface for pluggable task systems
- Show multiple reading experiences: Notion-style pages, Linear-style timelines, Git integration, CLI
- Update storage to support file system, SQLite, PostgreSQL, S3
- Revise migration path to prioritize format and adapters
Link to tweet and Pragmatic Engineer article on agent trajectories.
Include related observations on why trajectory capture matters:
more code faster, parallel agent work, bug diagnosis needs.
Add comprehensive "Notion for Agents" section:
- Knowledge workspace concept (decisions, patterns, knowledge base)
- Data model for AgentWorkspace, DecisionLog, PatternLibrary
- Population strategies (automatic, agent contribution, human curation)
- Query interface with contextual suggestions
- Flywheel effect for continuous improvement

Add claude-mem integration section:
- Comparison table (observation layer vs task layer)
- Agent Memory Stack diagram showing complementary roles
- Integration strategies (shared storage, cross-query, hooks)
- Export/import between formats
Add "Architecture: Separate Providers in a Stack" section showing:
- Each layer is an independent project (agent-relay, claude-mem,
  agent-trajectories, agent-workspace)
- Projects can be used alone or composed together
- Integration points between layers
- Why separate projects (independent adoption, different maintainers,
  cleaner dependencies)
- agent-relay as the communication substrate
- Remove agent-workspace as separate Layer 4
- Show workspace as nested feature within agent-trajectories
- Add project structure showing workspace/ as opt-in module
- Explain why combined: flywheel effect, simpler UX, derived data

Stack is now 3 separate providers:
1. agent-relay (messaging)
2. claude-mem (observations)
3. agent-trajectories (narratives + workspace)
Export StoredMessage, MessageQuery, StorageAdapter, and StorageConfig
types so agent-trajectories can import messages from agent-relay.

Example usage:
  import { StoredMessage, MessageQuery } from 'agent-relay';
Comprehensive guide covering:
- Phase 0: Current state (agent-relay, claude-mem)
- Phase 1: Installing claude-mem
- Phase 2: Creating agent-trajectories project structure
- Phase 3: agent-relay integration (import messages)
- Phase 4: claude-mem integration (import observations)
- Phase 5: Hook integration (combined hooks config)
- Phase 6: Complete setup and workflow

Includes code examples, data flow diagrams, and setup checklist.
khaliqgant pushed a commit that referenced this pull request Dec 21, 2025
Addresses storage requirements for federated deployments by separating:
- Ephemeral storage (routing): Memory or NATS JetStream for message queues
- Durable storage (trajectories): File/SQLite local + PostgreSQL/S3 central

References the trajectories proposal (PR #3) for detailed format specification.
Includes configuration examples and federation impact analysis.
@khaliqgant khaliqgant merged commit d7c3453 into main Dec 21, 2025
6 checks passed
khaliqgant added a commit that referenced this pull request Apr 1, 2026
template-resolver.ts: shell-escape interpolated variables (CRITICAL #1)
broker_tests.rs: uncomment and wire up 5 real tests (CRITICAL #2)
worker_tests.rs: uncomment and wire up 5 real tests (CRITICAL #3)
worker.rs: log bypass-flag injection, add .. path traversal rejection (CRITICAL #4, #7)
verification.ts: export stripInjectedTaskEcho, add path traversal guard (CRITICAL #5)
runner.ts: remove duplicate stripInjectedTaskEcho, add ENV_ALLOWLIST filtering (HIGH #17)
channel-messenger.ts: add secret scrubbing, hoist regex constants (MEDIUM #27, #28)
process-spawner.ts: add settled guard for race condition (MEDIUM #23)
step-executor.ts: add sideEffects to callback type, deprecate alias (HIGH #15, #16)
index.ts: export StepExecutor directly (MEDIUM #29)
workflows/refactor/*.ts: replace hardcoded paths, remove --no-verify (HIGH #8-11)
broker.rs: move is_pid_alive to canonical location (HIGH #14)
cost/tracker.ts: add restrictive file permissions (MEDIUM #30)
cost/pricing.ts: add last-verified date (MEDIUM #31)
verification.test.ts: 9 new tests for exported helpers (MEDIUM #32)

Co-Authored-By: My Senior Dev <dev@myseniordev.com>
khaliqgant added a commit that referenced this pull request Apr 6, 2026
…#675)

* refactor: TDD decomposition of runner.ts + main.rs with extracted modules

Extracted 5 modules from runner.ts (6,878 lines):
- verification.ts (143 lines)
- template-resolver.ts (87 lines)
- channel-messenger.ts (151 lines)
- step-executor.ts (571 lines)
- process-spawner.ts (96 lines)

Added characterization tests for all extracted modules.
Extracted broker.rs and worker.rs from main.rs.

Bug fixes:
- Restore stripInjectedTaskEcho in verification.ts
- Guard agent.release() against broker 400 race condition
- Fix run-summary-table test for new table format
- Export normalizeModel for correct pricing resolution
- Fix --wave argument parsing in run-refactor.ts
- ESM imports in all workflow files

* fix: address 10 review finding(s)

tracker.ts: resolveModel now uses normalizeModel for alias resolution (pre-existing fix verified)
run-refactor.ts: --wave parsing with proper validation (pre-existing fix verified)
step-executor.ts: signal-killed processes now correctly treated as failures
channel-messenger.ts: replaced ReDoS-vulnerable regex with iterative indexOf stripping
runner.ts: eliminated shell injection by using direct git spawn with argument arrays
process-spawner.ts: fixed SIGKILL fallback timer leak by storing and clearing reference

Co-Authored-By: My Senior Dev <dev@myseniordev.com>

* Revert "chore: gitignore .trajectories/ (automated run artifacts) (#676)" (#677)

This reverts commit 07a8dc0.

* refactor: TDD decomposition of runner.ts + main.rs with extracted modules

Extracted 5 modules from runner.ts (6,878 lines):
- verification.ts (143 lines)
- template-resolver.ts (87 lines)
- channel-messenger.ts (151 lines)
- step-executor.ts (571 lines)
- process-spawner.ts (96 lines)

Added characterization tests for all extracted modules.
Extracted broker.rs and worker.rs from main.rs.

Bug fixes:
- Restore stripInjectedTaskEcho in verification.ts
- Guard agent.release() against broker 400 race condition
- Fix run-summary-table test for new table format
- Export normalizeModel for correct pricing resolution
- Fix --wave argument parsing in run-refactor.ts
- ESM imports in all workflow files

* trajectories correction again

* pre commit is executable

* remove tracked workflows

* fix: address 36 review findings across Rust and TypeScript modules

template-resolver.ts: shell-escape interpolated variables (CRITICAL #1)
broker_tests.rs: uncomment and wire up 5 real tests (CRITICAL #2)
worker_tests.rs: uncomment and wire up 5 real tests (CRITICAL #3)
worker.rs: log bypass-flag injection, add .. path traversal rejection (CRITICAL #4, #7)
verification.ts: export stripInjectedTaskEcho, add path traversal guard (CRITICAL #5)
runner.ts: remove duplicate stripInjectedTaskEcho, add ENV_ALLOWLIST filtering (HIGH #17)
channel-messenger.ts: add secret scrubbing, hoist regex constants (MEDIUM #27, #28)
process-spawner.ts: add settled guard for race condition (MEDIUM #23)
step-executor.ts: add sideEffects to callback type, deprecate alias (HIGH #15, #16)
index.ts: export StepExecutor directly (MEDIUM #29)
workflows/refactor/*.ts: replace hardcoded paths, remove --no-verify (HIGH #8-11)
broker.rs: move is_pid_alive to canonical location (HIGH #14)
cost/tracker.ts: add restrictive file permissions (MEDIUM #30)
cost/pricing.ts: add last-verified date (MEDIUM #31)
verification.test.ts: 9 new tests for exported helpers (MEDIUM #32)

Co-Authored-By: My Senior Dev <dev@myseniordev.com>

* style: auto-format Rust code with cargo fmt

* minor clean

* fix: reinstate deleted workflow files into workflows/ci/

Moved fix-mcp-spawn.yaml, add-swift-sdk.ts, and cli-observability.ts
into workflows/ci/ to clearly distinguish them as CI test suite
workflows. Updated .gitignore to allow workflows/ci/ and workflows/refactor/.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address remaining Devin review findings and fix failing test

- Fix tracker test: expect mode: 0o700 in mkdirSync assertion
- Use Object.hasOwn() instead of `in` operator to avoid prototype chain false positives
- Use Promise.allSettled to preserve partial output on process timeout
- Apply path containment check for absolute paths in checkFileExists

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address new Devin review findings — StepExecutor name collision and cwd trailing slash

- Rename StepExecutor interface in runner.ts to RunnerStepExecutor to avoid
  shadowing the StepExecutor class export in the barrel index
- Normalize cwd with path.resolve() in checkFileExists to handle trailing slashes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@willwashburn willwashburn deleted the claude/store-task-conversations-Js8Py branch May 15, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants