[codex] Expose workspace fleet node flag in SDK#199
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds a Changesworkspace.fleetNodes SDK surface
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07f13e66db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Fleet node presence is published to the workspace stream (workspace-key | ||
| subscribers only) as `node.online`, `node.heartbeat`, and `node.offline`. Each |
There was a problem hiding this comment.
Remove docs for unimplemented node stream events
When users enable workspace stream and fleet nodes, these node.* events are never emitted by the current engine: I checked handleNodeControlMessage() for node.register/node.heartbeat, markNodeOffline()/sweepOfflineNodes(), and all publishToWorkspaceStream call sites, and node control only updates DB state/drains queues without publishing roster events. This docs addition will make workspace-key subscribers wait for node roster updates that never arrive; either implement the fanout or drop this paragraph.
Useful? React with 👍 / 👎.
Summary
Context
@relaycast/sdk@4.1.0 was published from main before this SDK helper reached main. This PR applies the helper directly to the release lineage so the next Relaycast SDK release ships it in the npm package.
Validation