Skip to content

Harden mount daemon recovery follow-ups#176

Merged
khaliqgant merged 1 commit into
mainfrom
codex/issue-175-mount-recovery
May 21, 2026
Merged

Harden mount daemon recovery follow-ups#176
khaliqgant merged 1 commit into
mainfrom
codex/issue-175-mount-recovery

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Summary

  • register foreground mount loops in the same PID state used by background daemons so relayfile status/stop can see active foreground mounts
  • refuse re-home on unverified mount PID state without deleting the evidence, while preserving the PR Fix mount reconcile drift and local-dir footguns #174 legacy localDir fallback
  • dedupe oversized local-file skip logs per path/size/cap and persist incremental event progress only after each applied page so large backlogs can converge after mid-pull errors

Issue coverage

Refs #175. This covers the remaining relayfile-side follow-ups C/E/F after #174 covered A/B/D. Cloud-side G/H remain out of scope for this repo.

Review

  • Codex subagent review: no findings after follow-up coverage was added
  • Claude review via agent-relay: no blockers; noted foreground PID cleanup, which is covered by the existing deferred pid-file removal

Verification

  • go test ./cmd/relayfile-cli -run 'TestMount(UsesLegacyRecordedLocalDirWhenOmitted|RefusesExplicitLocalDirThatRehomesRecordedMirror|RehomeRefusesRunningRecordedDaemon|RehomeRefusesUnverifiedRecordedDaemon|RehomeAllowsExplicitMoveAndPersistsLocalDir)|TestShouldRegisterMountPID|TestStatusIncludesLocalMirrorAndDaemonCounts' -count=3\n- go test ./internal/mountsync -run 'TestPullRemoteIncrementalPersistsAppliedPageCursorOnListEventsError|TestScanLocalFilesLogsOversizedFileOncePerSize|TestPullShortCircuitsWhenNoNewEvents|TestQuietEventCyclesEventuallyRunPeriodicFullPull|TestForceFullReconcile' -count=3\n- go test -count=1 ./...\n- scripts/check-contract-surface.sh\n- git diff --check --cached

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@khaliqgant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d2e1997-acd4-42bd-9dec-558753792dfc

📥 Commits

Reviewing files that changed from the base of the PR and between 58219ec and a7174b7.

📒 Files selected for processing (4)
  • cmd/relayfile-cli/main.go
  • cmd/relayfile-cli/main_test.go
  • internal/mountsync/syncer.go
  • internal/mountsync/syncer_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-175-mount-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-05-21T09-13-49-336Z-HEAD-provider
Mode: provider
Git SHA: a011d13

Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0

Human Review Cases

No reviewable human-review cases captured Relayfile output.

@khaliqgant khaliqgant merged commit 21e4fd8 into main May 21, 2026
9 of 10 checks passed
@khaliqgant khaliqgant deleted the codex/issue-175-mount-recovery branch May 21, 2026 09:16

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant