Fix generated workflow worktree gates#147
Conversation
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive set of agent trajectory logs, compactions, and summaries in both JSON and Markdown formats under the .agentworkforce/ directory. These files document the execution history, key decisions, conventions established, lessons learned, and statistics of various agent-run workflows (such as wave8, wave10, and wave12) for the Ricky project. There are no review comments on these changes, so I have no feedback to provide.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 371 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".agentworkforce/trajectories/completed/2026-04/traj_0crqhj2jmg33.md">
<violation number="1" location=".agentworkforce/trajectories/completed/2026-04/traj_0crqhj2jmg33.md:38">
P3: Redundant and structurally ambiguous bullet point in the Chapters section. The text is duplicated as both label and value (`A: A`), and the item floats at the chapters level instead of being nested under a specific chapter. This adds no information and could confuse automated trajectory parsers or readers.</violation>
</file>
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
| ### 3. Execution: write-proof-verdict | ||
| *Agent: proof-codex* | ||
|
|
||
| - Kept existing live proof verdict document content: Kept existing live proof verdict document content |
There was a problem hiding this comment.
P3: Redundant and structurally ambiguous bullet point in the Chapters section. The text is duplicated as both label and value (A: A), and the item floats at the chapters level instead of being nested under a specific chapter. This adds no information and could confuse automated trajectory parsers or readers.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .agentworkforce/trajectories/completed/2026-04/traj_0crqhj2jmg33.md, line 38:
<comment>Redundant and structurally ambiguous bullet point in the Chapters section. The text is duplicated as both label and value (`A: A`), and the item floats at the chapters level instead of being nested under a specific chapter. This adds no information and could confuse automated trajectory parsers or readers.</comment>
<file context>
@@ -0,0 +1,38 @@
+### 3. Execution: write-proof-verdict
+*Agent: proof-codex*
+
+- Kept existing live proof verdict document content: Kept existing live proof verdict document content
</file context>
|
Reviewed PR #147 and made the needed fixes. Changed:
Verified locally:
|
|
Reviewed PR #147 and made the needed fixes. Changed:
Verified locally:
|
![agent-relay-code[bot]](https://avatars.githubusercontent.com/in/3624277?s=60&v=4){kind=small}
There was a problem hiding this comment.
1) — fixes were not applied to the PR. The notes below are advisory and were not pushed.
Reviewed PR #147 and made the needed fixes.
Changed:
- Tightened structured persona disk recovery so
writerInvokedAtMsalso prevents stale artifact reuse there. - Added regression coverage for stale structured placeholder recovery.
- Fixed proof tests that were failing locally:
- flat-layout proof now excludes harness/build/history outputs from active source scans.
- external CLI proof uses
sh -cso the linkedrickybinary remains onPATH.
Verified locally:
npx tsc --noEmitnpm test→ 59 passed, 1 skipped, 1262 tests passed
|
Reviewed and fixed PR #147 locally. Changes made:
Validation run:
|
|
✅ pr-reviewer applied fixes — committed and pushed Reviewed and fixed PR #147 locally. Changes made:
Validation run:
|
There was a problem hiding this comment.
✅ pr-reviewer applied fixes — committed and pushed bc9999c to this PR. The notes below describe what changed.
Reviewed and fixed PR #147 locally.
Changes made:
- Resolved bot review comments on trajectory artifacts:
- Sanitized leaked absolute
projectIdpaths. - Moved the reviewed May-dated trajectory into
completed/2026-05. - Removed the redundant malformed markdown bullet.
- Sanitized leaked absolute
- Fixed a generated-workflow gate false positive so
test -fon extensionless executables underbin/orscripts/is allowed. - Updated the flat-layout proof scanner to ignore archived
.agentworkforce/trajectories/files as historical records, not active repo references.
Validation run:
npm run typecheckpassed.- Focused generation tests passed: 155 tests.
- Full
npm testpassed: 61 files, 1388 tests, 1 skipped.
|
Reviewed and fixed PR #147 locally. Changes made:
Verification run locally:
|
|
Reviewed and fixed PR #147 locally. Changes made:
Verification run locally:
|
There was a problem hiding this comment.
Reviewed and fixed PR #147 locally.
Changes made:
- Hardened structured persona disk recovery so
writerInvokedAtMsalso blocks stale artifact reuse. - Added regression coverage for stale structured placeholder recovery.
- Fixed flat-layout proof scans to ignore inert
.agentworkforcetrajectory history. - Resolved bot-reviewed trajectory hygiene issues: removed leaked absolute local paths, moved the May 1 trajectory into
2026-05, and cleaned the ambiguous Markdown bullet. - Checked PR bot feedback on GitHub: #147
Verification run locally:
npm run typechecknpm test→ 61 passed, 1 skipped; 1388 passed, 1 skipped- trajectory JSON parse check →
JSON_PARSE_OK 197
|
Reviewed PR #147 and fixed one issue: Local verification completed: No additional bot review artifacts were present in |
|
Reviewed PR #147 and fixed one issue: Local verification completed: No additional bot review artifacts were present in |
There was a problem hiding this comment.
Reviewed PR #147 and fixed one issue: test/flat-layout-proof/flat-layout-proof.ts was using regex to scan TypeScript imports. I replaced it with a TypeScript AST walk covering imports, re-exports, dynamic imports, and require() calls.
Local verification completed:
npm run typecheck
npm test - 61 passed, 1 skipped
No additional bot review artifacts were present in .workforce.
|
Reviewed and fixed PR #147 locally. Changed test/flat-layout-proof/flat-layout-proof.ts to replace regex-based TypeScript import scanning with a Local verification passed: |
There was a problem hiding this comment.
Reviewed and fixed PR #147 locally.
Changed test/flat-layout-proof/flat-layout-proof.ts to replace regex-based TypeScript import scanning with a ts.createSourceFile AST walk for imports, exports, dynamic imports, and require(...), matching the repo’s parser-aware source-text rule.
Local verification passed:
npm run typecheck
npx vitest run src/product/generation/workforce-persona-writer.test.ts
npx tsx test/flat-layout-proof/flat-layout-proof.ts
npm test with 1388 passed, 1 skipped
|
Reviewed PR #147 and fixed the remaining issue from bot feedback. Changed test/flat-layout-proof/flat-layout-proof.ts to extract TypeScript module specifiers with Added regression coverage in flat-layout-proof.test.ts. Local validation passed:
|
|
Reviewed PR #147 and fixed the remaining issue from bot feedback. Changed test/flat-layout-proof/flat-layout-proof.ts to extract TypeScript module specifiers with Added regression coverage in flat-layout-proof.test.ts. Local validation passed:
|
There was a problem hiding this comment.
Reviewed PR #147 and fixed the remaining issue from bot feedback.
Changed test/flat-layout-proof/flat-layout-proof.ts to extract TypeScript module specifiers with ts.createSourceFile instead of regex, covering imports, re-exports, dynamic imports, require(), and import = require() without matching comments or strings.
Added regression coverage in flat-layout-proof.test.ts.
Local validation passed:
npm run typechecknpx vitest run src/product/generation/workforce-persona-writer.test.tsnpx vitest run test/flat-layout-proof/flat-layout-proof.test.tsnpx tsx test/flat-layout-proof/flat-layout-proof.ts- changed JSON parse sweep:
JSON_PARSE_OK 198 npm test: 61 passed, 1 skipped; 1389 tests passed, 1 skipped
|
Reviewed PR #147 and fixed the remaining issue from bot feedback. Changed Local validation passed:
|
|
Reviewed PR #147 and fixed the remaining issue from bot feedback. Changed Local validation passed:
|
There was a problem hiding this comment.
Reviewed PR #147 and fixed the remaining issue from bot feedback.
Changed test/flat-layout-proof/flat-layout-proof.ts to use a TypeScript AST walk for module specifier extraction, including imports, re-exports, dynamic imports, require(), import type(...), and import = require(...), without matching comments or strings. Added regression coverage in test/flat-layout-proof/flat-layout-proof.test.ts.
Local validation passed:
npm run typechecknpx vitest run src/product/generation/workforce-persona-writer.test.tsnpx vitest run test/flat-layout-proof/flat-layout-proof.test.tsnpx tsx test/flat-layout-proof/flat-layout-proof.ts- changed JSON parse sweep:
JSON_PARSE_OK 198 npm test: 61 passed, 1 skipped; 1389 passed, 1 skipped
1 participant
Summary
test -fgates for directories, worktree roots, and glob paths..agentworkforcetrajectory artifacts for the local work history.Tests