Skip to content

chore: bump default run timeout from 10m to 30m#50

Closed
khaliqgant wants to merge 1 commit into
mainfrom
chore/bump-default-run-timeout
Closed

chore: bump default run timeout from 10m to 30m#50
khaliqgant wants to merge 1 commit into
mainfrom
chore/bump-default-run-timeout

Conversation

@khaliqgant

Copy link
Copy Markdown
Member

Summary

  • Bump DEFAULT_RUN_TIMEOUT_MS (and the aliased DEFAULT_TIMEOUT_MS) from 600_000 to 1_800_000.
  • Newly generated workflows pick this up automatically in their .timeout() call (via template-renderer.ts).

Why

The 10-minute ceiling kills real implementation runs before the workflow's own timeout matters. We hit this resuming a code-writing workflow where the implement step (single codex worker + gates) consistently runs longer than 10 minutes. Ricky surfaces the failure as MISSING_ENV_VAR at runtime-launch because the outer launcher timeout fires inside the env-blocker classification path — so the user sees a misleading export API=... next-step suggestion. Bumping the default avoids that misclassification for the common case.

This is the minimal change. A follow-up could expose --timeout-ms / RICKY_RUN_TIMEOUT_MS for per-run overrides, but the default alone unblocks the typical path.

Test plan

  • npx tsc --noEmit clean
  • npx vitest run src/runtime/local-coordinator.test.ts src/product/generation/ src/product/specialists/validator/validator.test.ts — 93 tests pass
  • Manual: regenerate a workflow and confirm the rendered .timeout(1_800_000)

🤖 Generated with Claude Code

Real implementation steps in generated workflows routinely need more than
10 minutes (a single codex/claude worker doing meaningful work, plus the
gates around it). The 600s ceiling was killing runs as MISSING_ENV_VAR
when the actual cause was just the outer launcher timeout firing.

DEFAULT_TIMEOUT_MS aliases this constant, so newly generated workflows
also inherit the bump in their .timeout() call.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd0807b6-7430-4f31-bc55-eba37575526b

📥 Commits

Reviewing files that changed from the base of the PR and between 94f656c and abfde16.

📒 Files selected for processing (1)
  • src/shared/constants.ts

📝 Walkthrough

Walkthrough

A timeout constant is increased from 600,000 to 1,800,000 milliseconds (10 minutes to 30 minutes) in the shared constants file.

Changes

Timeout Configuration

Layer / File(s) Summary
Configuration Update
src/shared/constants.ts
DEFAULT_RUN_TIMEOUT_MS increased from 600_000 to 1_800_000 milliseconds, extending the default run timeout from 10 to 30 minutes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A timeout stretched from ten to thirty,
More time to think before we're flurry,
With patient seconds counting long,
Our steady runs grow strong and strong! ⏱️✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: bumping the default run timeout from 10 minutes to 30 minutes, which accurately matches the constant value change in the PR.
Description check ✅ Passed The description is directly related to the changeset, providing a clear summary of the timeout constant update, the rationale for the change, and a comprehensive test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-default-run-timeout

Comment @coderabbitai help to get the list of available commands and usage tips.

@khaliqgant

Copy link
Copy Markdown
Member Author

Closing in favor of #51, which fixes the underlying issue (timeout misclassification + restored per-step timeouts) rather than just bumping the default. PR #51 also bumps the default to 45 min as a safety net, so this PR's behavior is fully covered there.

@khaliqgant khaliqgant closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant