chore: bump default run timeout from 10m to 30m#50
Closed
khaliqgant wants to merge 1 commit into
Closed
Conversation
Real implementation steps in generated workflows routinely need more than 10 minutes (a single codex/claude worker doing meaningful work, plus the gates around it). The 600s ceiling was killing runs as MISSING_ENV_VAR when the actual cause was just the outer launcher timeout firing. DEFAULT_TIMEOUT_MS aliases this constant, so newly generated workflows also inherit the bump in their .timeout() call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA timeout constant is increased from 600,000 to 1,800,000 milliseconds (10 minutes to 30 minutes) in the shared constants file. ChangesTimeout Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
5 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_RUN_TIMEOUT_MS(and the aliasedDEFAULT_TIMEOUT_MS) from600_000to1_800_000..timeout()call (viatemplate-renderer.ts).Why
The 10-minute ceiling kills real implementation runs before the workflow's own timeout matters. We hit this resuming a code-writing workflow where the implement step (single codex worker + gates) consistently runs longer than 10 minutes. Ricky surfaces the failure as
MISSING_ENV_VAR at runtime-launchbecause the outer launcher timeout fires inside the env-blocker classification path — so the user sees a misleadingexport API=...next-step suggestion. Bumping the default avoids that misclassification for the common case.This is the minimal change. A follow-up could expose
--timeout-ms/RICKY_RUN_TIMEOUT_MSfor per-run overrides, but the default alone unblocks the typical path.Test plan
npx tsc --noEmitcleannpx vitest run src/runtime/local-coordinator.test.ts src/product/generation/ src/product/specialists/validator/validator.test.ts— 93 tests pass.timeout(1_800_000)🤖 Generated with Claude Code