Emit repair-aware generated workflows #75
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,6 @@ coverage/ | |
| .agent-relay.stale.*/ | ||
| .relay/ | ||
| .ricky/ | ||
| .workflow-artifacts/ | ||
| .factory/ | ||
| .mcp.json | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "id": "traj_2f8sfg3akql2", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Harden Ricky workflow never-fail coverage" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-05-08T14:46:04.652Z", | ||
| "completedAt": "2026-05-08T14:54:06.222Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-05-08T14:48:29.461Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_e5f3y6nkmd4t", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-05-08T14:48:29.461Z", | ||
| "endedAt": "2026-05-08T14:54:06.222Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1778251709462, | ||
| "type": "decision", | ||
| "content": "Harden generated workflows with repair-aware retry instead of fail-fast: Harden generated workflows with repair-aware retry instead of fail-fast", | ||
| "raw": { | ||
| "question": "Harden generated workflows with repair-aware retry instead of fail-fast", | ||
| "chosen": "Harden generated workflows with repair-aware retry instead of fail-fast", | ||
| "alternatives": [], | ||
| "reasoning": "Relay now supports deterministic gate repair agents; Ricky should emit workflows that opt into that behavior for ordinary, master, and child workflows so generated workflows do not terminate on repairable checks." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1778252041693, | ||
| "type": "reflection", | ||
| "content": "Ricky generator now emits repair-aware retry for ordinary, master, and child workflows; pipeline tests cover code, doc, low-risk, and master shapes; local auto-fix and full suite are green after syncing package proof script allowlist.", | ||
| "raw": { | ||
| "confidence": 0.9 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "confidence:0.9" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Hardened Ricky workflow generation so generated workflows opt into repair-aware retry with repairAgent/repairRetries, added validation and generation tests across code, doc, low-risk, master, and child workflow shapes, kept local auto-fix coverage green, and synced package proof/docs for existing eval scripts so the full suite passes.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.92 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "33549385e357061346be25e7be0c64d49abdfef9", | ||
| "endRef": "33549385e357061346be25e7be0c64d49abdfef9" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Trajectory: Harden Ricky workflow never-fail coverage | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 92% | ||
| > **Started:** May 8, 2026 at 04:46 PM | ||
| > **Completed:** May 8, 2026 at 04:54 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Hardened Ricky workflow generation so generated workflows opt into repair-aware retry with repairAgent/repairRetries, added validation and generation tests across code, doc, low-risk, master, and child workflow shapes, kept local auto-fix coverage green, and synced package proof/docs for existing eval scripts so the full suite passes. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Harden generated workflows with repair-aware retry instead of fail-fast | ||
| - **Chose:** Harden generated workflows with repair-aware retry instead of fail-fast | ||
| - **Reasoning:** Relay now supports deterministic gate repair agents; Ricky should emit workflows that opt into that behavior for ordinary, master, and child workflows so generated workflows do not terminate on repairable checks. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Harden generated workflows with repair-aware retry instead of fail-fast: Harden generated workflows with repair-aware retry instead of fail-fast | ||
| - Ricky generator now emits repair-aware retry for ordinary, master, and child workflows; pipeline tests cover code, doc, low-risk, and master shapes; local auto-fix and full suite are green after syncing package proof script allowlist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| { | ||
| "id": "traj_b77ch3xz99r8", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Avoid master child workflow false terminal failures" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-05-08T15:04:46.241Z", | ||
| "completedAt": "2026-05-08T15:12:41.150Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-05-08T15:12:30.504Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_c2qwv9dhlskk", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-05-08T15:12:30.504Z", | ||
| "endedAt": "2026-05-08T15:12:41.150Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1778253150505, | ||
| "type": "decision", | ||
| "content": "Keep nested Ricky child auto-fix enabled from master workflows: Keep nested Ricky child auto-fix enabled from master workflows", | ||
| "raw": { | ||
| "question": "Keep nested Ricky child auto-fix enabled from master workflows", | ||
| "chosen": "Keep nested Ricky child auto-fix enabled from master workflows", | ||
| "alternatives": [], | ||
| "reasoning": "The cloud failure showed master-generated child runs using --no-auto-fix, which prevented the child workflow from repairing its own deterministic blocker before the master failed." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1778253150534, | ||
| "type": "decision", | ||
| "content": "Make generated child final validation non-terminal: Make generated child final validation non-terminal", | ||
| "raw": { | ||
| "question": "Make generated child final validation non-terminal", | ||
| "chosen": "Make generated child final validation non-terminal", | ||
| "alternatives": [], | ||
| "reasoning": "Parallel child workflows can observe temporary integrated-repo typecheck failures caused by sibling slices; the master final validation should own the hard integrated check after all child signoffs." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1778253150554, | ||
| "type": "decision", | ||
| "content": "Retry after workflow repair provider exceptions: Retry after workflow repair provider exceptions", | ||
| "raw": { | ||
| "question": "Retry after workflow repair provider exceptions", | ||
| "chosen": "Retry after workflow repair provider exceptions", | ||
| "alternatives": [], | ||
| "reasoning": "Malformed or missing structured artifacts from the repair persona should consume a bounded retry and resume the workflow, not stop the auto-fix loop after the first attempt." | ||
| }, | ||
| "significance": "high" | ||
| }, | ||
| { | ||
| "ts": 1778253156553, | ||
| "type": "reflection", | ||
| "content": "Generated workflows now keep repair loops active at both master and child layers, and legacy artifacts get deterministic repair for the old no-auto-fix and hard child validation patterns.", | ||
| "raw": { | ||
| "focalPoints": [ | ||
| "nested-auto-fix", | ||
| "parallel-validation", | ||
| "repair-provider-resilience" | ||
| ], | ||
| "adjustments": "Added regression coverage for generation, deterministic legacy repair, and provider exception retry.", | ||
| "confidence": 0.9 | ||
| }, | ||
| "significance": "high", | ||
| "tags": [ | ||
| "focal:nested-auto-fix", | ||
| "focal:parallel-validation", | ||
| "focal:repair-provider-resilience", | ||
| "confidence:0.9" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Updated Ricky workflow generation and auto-fix resilience so generated master workflows keep nested child auto-fix enabled, generated child final validation no longer terminally blocks on parallel sibling repo state, legacy generated artifacts can be deterministically repaired, and repair-provider exceptions trigger bounded retry/resume instead of immediate failure.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.9 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "800ddc84f3a68aa0c7edc6cdcfd513c612d8adf5", | ||
| "endRef": "800ddc84f3a68aa0c7edc6cdcfd513c612d8adf5" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Trajectory: Avoid master child workflow false terminal failures | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 90% | ||
| > **Started:** May 8, 2026 at 05:04 PM | ||
| > **Completed:** May 8, 2026 at 05:12 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Updated Ricky workflow generation and auto-fix resilience so generated master workflows keep nested child auto-fix enabled, generated child final validation no longer terminally blocks on parallel sibling repo state, legacy generated artifacts can be deterministically repaired, and repair-provider exceptions trigger bounded retry/resume instead of immediate failure. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Keep nested Ricky child auto-fix enabled from master workflows | ||
| - **Chose:** Keep nested Ricky child auto-fix enabled from master workflows | ||
| - **Reasoning:** The cloud failure showed master-generated child runs using --no-auto-fix, which prevented the child workflow from repairing its own deterministic blocker before the master failed. | ||
|
|
||
| ### Make generated child final validation non-terminal | ||
| - **Chose:** Make generated child final validation non-terminal | ||
| - **Reasoning:** Parallel child workflows can observe temporary integrated-repo typecheck failures caused by sibling slices; the master final validation should own the hard integrated check after all child signoffs. | ||
|
|
||
| ### Retry after workflow repair provider exceptions | ||
| - **Chose:** Retry after workflow repair provider exceptions | ||
| - **Reasoning:** Malformed or missing structured artifacts from the repair persona should consume a bounded retry and resume the workflow, not stop the auto-fix loop after the first attempt. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Keep nested Ricky child auto-fix enabled from master workflows: Keep nested Ricky child auto-fix enabled from master workflows | ||
| - Make generated child final validation non-terminal: Make generated child final validation non-terminal | ||
| - Retry after workflow repair provider exceptions: Retry after workflow repair provider exceptions | ||
| - Generated workflows now keep repair loops active at both master and child layers, and legacy artifacts get deterministic repair for the old no-auto-fix and hard child validation patterns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||
| { | ||||||
| "version": 1, | ||||||
| "lastUpdated": "2026-05-08T15:12:41.286Z", | ||||||
| "trajectories": { | ||||||
| "traj_2f8sfg3akql2": { | ||||||
| "title": "Harden Ricky workflow never-fail coverage", | ||||||
| "status": "completed", | ||||||
| "startedAt": "2026-05-08T14:46:04.652Z", | ||||||
| "completedAt": "2026-05-08T14:54:06.222Z", | ||||||
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail/.trajectories/completed/2026-05/traj_2f8sfg3akql2.json" | ||||||
|
Contributor
There was a problem hiding this comment. Absolute path in committed index may cause portability issues. The 🔧 Suggested fix- "path": "/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail/.trajectories/completed/2026-05/traj_2f8sfg3akql2.json"
+ "path": ".trajectories/completed/2026-05/traj_2f8sfg3akql2.json"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| }, | ||||||
| "traj_b77ch3xz99r8": { | ||||||
| "title": "Avoid master child workflow false terminal failures", | ||||||
| "status": "completed", | ||||||
| "startedAt": "2026-05-08T15:04:46.241Z", | ||||||
| "completedAt": "2026-05-08T15:12:41.150Z", | ||||||
| "path": "/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail/.trajectories/completed/2026-05/traj_b77ch3xz99r8.json" | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Trajectory index contains hardcoded absolute local path that breaks on all other machines
The
.trajectories/index.jsonfile (newly tracked after removing.trajectories/from.gitignore) stores the trajectory path as an absolute local filesystem path:/Users/khaliqgant/Projects/AgentWorkforce/ricky-workflow-never-fail/.trajectories/completed/2026-05/traj_2f8sfg3akql2.json. ThetrailCLI tool (documented inAGENTS.md:86-170) uses this index to resolve trajectory files via commands liketrail show <id>andtrail list. On any machine other than the original author's, this path is invalid, making the index functionally broken for trajectory resolution. The same absolute path pattern appears inprojectIdat.trajectories/completed/2026-05/traj_2f8sfg3akql2.json:59.Was this helpful? React with 👍 or 👎 to provide feedback.