docs(creating-cloud-persona): optional integrations + dual-transport pattern#83
Conversation
…tions + dual-transport pattern Adds optional/enabledByInput to the PersonaIntegrationConfig type and a new §3b covering opt-in integrations (persona-kit ≥4.1.12) and the canonical dual-transport agent (one agent declaring both slack + telegram, gated by input, dispatching by event type and replying on the origin transport). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 53 minutes and 35 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c4427bc4d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `PersonaIntegrationConfig { source?: IntegrationSource; scope?: Record<string, string>; config?: Record<string, unknown> }`, | ||
| where `scope` maps a resource name to an absolute relayfile glob and `config` | ||
| passes provider-owned adapter settings through unchanged. An **unscoped | ||
| `PersonaIntegrationConfig { source?: IntegrationSource; scope?: Record<string, string>; config?: Record<string, unknown>; optional?: boolean; enabledByInput?: string }`, |
There was a problem hiding this comment.
Align optional integration docs with bundled persona-kit
The skill tells authors to use the vendored “current” references, but this advertised type does not match them: skills/creating-cloud-persona/references/workforce/packages/persona-kit/src/types.ts still defines PersonaIntegrationConfig with only source, scope, and config, and the schema mirrors that. With the self-contained refs/references/agents/package.json still on @agentworkforce/persona-kit ^3.0.47, examples using optional and enabledByInput will either fail TypeScript checks or be compiled without the gating fields, so the supposedly optional provider can still connect unconditionally. Please update the vendored persona-kit/schema/package references alongside this guidance or explicitly scope it to repos that have already upgraded.
Useful? React with 👍 / 👎.
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. Confirmed: the inline type string in SKILL.md:165 (updated by this PR) now lists 5 fields, but the vendored reference type at types.ts:250 lists only 3. The SKILL.md prose is the only place updated. My review is complete. This is a documentation-only PR with no buildable code, no CI workflows, and no review comments to address. There is nothing mechanical to auto-fix (formatting and markdown are clean). The one substantive finding — the vendored reference type/schema not matching the newly-documented fields — requires human judgment (regenerating snapshots from persona-kit 4.1.12 or confirming the exact shipped shape), so I'm leaving it as a review comment rather than fabricating type definitions. I made no edits to the working tree. Review: PR #83 —
|
Documents the workforce#252 optional integrations feature in the
creating-cloud-personaskill, which previously describedPersonaIntegrationConfigas just{ source, scope, config }and had no dual-transport guidance.optional?: boolean+enabledByInput?: stringto the type signature in §3.enabledByInputprunes a provider's connection/trigger/mount when the input is empty, the gate-on-id semantics, keeping data sources non-optional, and the version requirement.slack+telegram, dispatch byevent.type, reply-on-origin) — the pattern now shipping in the agents repo (inbox-buddy, joke-bot, spotify-releases, hn-monitor).Companion to AgentWorkforce/agents#91.
🤖 Generated with Claude Code