Skip to content

fix(ci): unswap persona publish workflows#185

Merged
khaliqgant merged 1 commit into
mainfrom
fix/swap-persona-publish-workflows
Jun 3, 2026
Merged

fix(ci): unswap persona publish workflows#185
khaliqgant merged 1 commit into
mainfrom
fix/swap-persona-publish-workflows

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jun 3, 2026

Copy link
Copy Markdown
Member

User description

What

The contents of publish-internal-personas.yml and publish-persona.yml were swapped. This restores each workflow to its intended role.

publish-internal-personas.yml → per-persona packs

  • Publishes the @agentworkforce/persona-* packs, selected by the agentworkforce.personas package.json field — currently persona-autonomous-actor and persona-nango-integrations.
  • Excludes @agentworkforce/personas-core.
  • No GitHub release — just bump / test / pack / publish to npm (+ optional version commit & tag).
  • Gets its own concurrency group so it doesn't share a lock with the core workflow.

publish-persona.yml → personas-core bundle

  • Publishes @agentworkforce/personas-core, including the GitHub Release job.

Also fixed the cross-reference comments / trusted-publisher notes in both file headers.

Why

"internal-personas" should publish only the persona-autonomous-actor and persona-nango-integrations packs, do no release, and never touch personas-core. The recent fix(publish-persona): select persona packs by agentworkforce.personas field commit landed that pack-selection logic in the wrong file.

🤖 Generated with Claude Code


CodeAnt-AI Description

Restore the persona publish workflows to their intended jobs

What Changed

  • The internal persona workflow now publishes only the per-persona @agentworkforce/persona-* packages, and it no longer creates a GitHub Release.
  • The core persona workflow is back to publishing @agentworkforce/personas-core and keeps the release step.
  • The internal workflow can now publish all persona packs or a selected subset, and it rejects invalid package names before publishing.
  • Internal persona publishes now use their own lock so they do not block or overlap with the core persona workflow.

Impact

✅ Correct persona packages published
✅ Fewer mistaken releases
✅ Safer manual publishes for persona packs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

The contents of publish-internal-personas.yml and publish-persona.yml
were swapped. Restore intended roles:

- publish-internal-personas.yml now publishes the per-persona
  @agentworkforce/persona-* packs (persona-autonomous-actor,
  persona-nango-integrations), selected by the agentworkforce.personas
  field, excluding personas-core. No GitHub release.
- publish-persona.yml now publishes the @agentworkforce/personas-core
  bundle, including the GitHub Release job.

Also fix cross-reference comments and give the internal workflow its
own concurrency group.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codeant-ai

codeant-ai Bot commented Jun 3, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a31cd488-5260-4e57-a939-b46da2655df8

📥 Commits

Reviewing files that changed from the base of the PR and between 37ed4ef and 2c396fc.

📒 Files selected for processing (2)
  • .github/workflows/publish-internal-personas.yml
  • .github/workflows/publish-persona.yml

📝 Walkthrough

Walkthrough

Two GitHub Actions workflows were repurposed to invert their publishing scope. The publish-internal-personas.yml workflow now discovers and publishes multiple internal persona packs from packages/persona-* with matrix-driven per-package version bumping, testing, packing, and npm publishing. The publish-persona.yml workflow now focuses exclusively on publishing @agentworkforce/personas-core with version management, trusted npm publishing, git tagging, and automated GitHub release note generation.

Changes

Multi-package internal personas publishing

Layer / File(s) Summary
Workflow inputs and concurrency
.github/workflows/publish-internal-personas.yml lines 1–63
Top-level workflow configuration now accepts package selector (single pack, multiple, or all) and version input (bump type, none, or exact semver); npm OIDC permissions and publish-internal-personas concurrency group configured.
Package discovery and matrix generation
.github/workflows/publish-internal-personas.yml lines 76–143
Dynamic bash/node script scans packages/, filters packages declaring agentworkforce.personas marker, excludes @agentworkforce/personas-core, matches user selector, and outputs JSON matrix for parallel per-pack jobs.
Per-package version, test, pack, and publish
.github/workflows/publish-internal-personas.yml lines 144–228
Matrix job loop: conditionally bumps version in each target's package.json (or keeps current when version: none), validates via npm view that target version is unpublished, runs per-package test suite, creates tarball via pnpm pack, publishes to npm with --provenance (or --dry-run), commits and creates git tags when not dry-running.
Conditional push
.github/workflows/publish-internal-personas.yml lines 230–232
Final step pushes commits and tags only when not in dry-run mode and version is not none.

Single-package personas-core publishing and release

Layer / File(s) Summary
Workflow inputs and output configuration
.github/workflows/publish-persona.yml lines 1–62
Workflow dispatch inputs redefined: version (bump type), custom_version (exact semver override), prerelease_id, tag (npm dist-tag), and dry_run flag; npm trusted publishing permissions and job outputs added for downstream release creation.
Package resolution, validation, and version bumping
.github/workflows/publish-persona.yml lines 75–137
Hardcoded resolution of packages/personas-core, lint validation via pnpm --filter, version bump in package.json supporting custom override and pre-release semantics, npm view check to prevent publishing existing versions, and conditional git commit of version bump.
Pack and publish to npm
.github/workflows/publish-persona.yml lines 138–174
Latest npm installation, temp pack directory setup, tarball creation via pnpm pack, tarball path computation, and npm publish with --provenance or --dry-run plus requested dist-tag.
Git tagging and push
.github/workflows/publish-persona.yml lines 175–190
Annotated tag creation (personas-core-v${version}), tag push, and step summary recording published package@version, dist-tag, and dry-run flag.
GitHub release note generation
.github/workflows/publish-persona.yml lines 191–243
New create-release job checks out release tag, reads packages/personas-core/package.json and persona JSON files, generates markdown release notes via inline Node script, and creates GitHub release with prerelease detection based on version string format.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • AgentWorkforce/workforce#43: Introduced the @agentworkforce/personas-core package and initial publish workflow that this PR refactors to swap roles between multi-pack and single-pack publishing.

Poem

🐰 Two workflows, swapped like spring rabbits at dawn,

One scatters many packs, the other holds one strong—

Discovery, matrix, and tags all align,

While core gets its release notes, polished and fine! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/swap-persona-publish-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@khaliqgant khaliqgant merged commit 52cc5da into main Jun 3, 2026
2 of 3 checks passed
@khaliqgant khaliqgant deleted the fix/swap-persona-publish-workflows branch June 3, 2026 08:02
@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Jun 3, 2026
@codeant-ai

codeant-ai Bot commented Jun 3, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

@agent-relay-code

Copy link
Copy Markdown
Contributor

Reviewed PR #185 and made scoped fixes.

Changed:

  • Hardened internal persona-pack discovery to only include scoped @agentworkforce/persona-* packs and sort targets deterministically.
  • Added a workflow summary table for internal persona publish runs.
  • Updated stale workflow references in publish.yml comments and persona pack READMEs.
  • Checked PR bot comments; no actionable bot findings were present.

Local verification passed:

  • corepack pnpm -r run build
  • corepack pnpm run lint
  • corepack pnpm run typecheck
  • corepack pnpm run test
  • Parsed the changed publish workflows with the installed YAML parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant