Skip to content

fix(publish): drop npm workspaces field that broke npm version (EUNSUPPORTEDPROTOCOL) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jun 4, 2026
Merged

fix(publish): drop npm workspaces field that broke npm version (EUNSUPPORTEDPROTOCOL) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/publish-internal-personas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,15 @@ jobs:
echo "::group::Preparing $NAME ($DIR)"

pushd "$DIR" >/dev/null
# --workspaces-update=false keeps `npm version` from reifying the root
# lockfile, which fails on pnpm's workspace:* protocol if an npm
# `workspaces` field ever appears in the root package.json.
if [ "$INPUT_VERSION" = "none" ]; then
:
elif [[ "$INPUT_VERSION" == pre* ]]; then
npm version "$INPUT_VERSION" --no-git-tag-version --preid="$INPUT_PREID"
npm version "$INPUT_VERSION" --no-git-tag-version --preid="$INPUT_PREID" --workspaces-update=false
else
npm version "$INPUT_VERSION" --no-git-tag-version --allow-same-version
npm version "$INPUT_VERSION" --no-git-tag-version --allow-same-version --workspaces-update=false
fi
VERSION=$(node -p 'require("./package.json").version')
popd >/dev/null
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/publish-persona.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,17 @@ jobs:
BUMP='${{ github.event.inputs.version }}'
PREID='${{ github.event.inputs.prerelease_id }}'

# --workspaces-update=false keeps `npm version` from reifying the root
# lockfile, which fails on pnpm's workspace:* protocol if an npm
# `workspaces` field ever appears in the root package.json.
if [ -n "$CUSTOM" ]; then
npm version "$CUSTOM" --no-git-tag-version --allow-same-version
npm version "$CUSTOM" --no-git-tag-version --allow-same-version --workspaces-update=false
elif [ "$BUMP" = "none" ]; then
: # keep existing version
elif [[ "$BUMP" == pre* ]]; then
npm version "$BUMP" --no-git-tag-version --preid="$PREID"
npm version "$BUMP" --no-git-tag-version --preid="$PREID" --workspaces-update=false
else
npm version "$BUMP" --no-git-tag-version
npm version "$BUMP" --no-git-tag-version --workspaces-update=false
fi

VERSION=$(node -p 'require("./package.json").version')
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ jobs:
}

for (const e of heals) {
execSync(`npm version ${baseline} --no-git-tag-version --allow-same-version`, {
// --workspaces-update=false: with any npm `workspaces` config in scope,
// `npm version` otherwise tries to reify the root lockfile and dies on
// pnpm's workspace:* protocol (EUNSUPPORTEDPROTOCOL).
execSync(`npm version ${baseline} --no-git-tag-version --allow-same-version --workspaces-update=false`, {
cwd: `packages/${e.pkg}`,
stdio: 'inherit',
});
Expand All @@ -196,14 +199,17 @@ jobs:
PREID='${{ github.event.inputs.prerelease_id }}'
for pkg in ${{ steps.targets.outputs.packages }}; do
pushd "packages/$pkg" > /dev/null
# --workspaces-update=false keeps `npm version` from reifying the root
# lockfile, which fails on pnpm's workspace:* protocol if an npm
# `workspaces` field ever appears in the root package.json.
if [ -n "$CUSTOM" ]; then
npm version "$CUSTOM" --no-git-tag-version --allow-same-version
npm version "$CUSTOM" --no-git-tag-version --allow-same-version --workspaces-update=false
elif [ "$BUMP" = "none" ]; then
: # keep existing version (useful for first publish or re-publish)
elif [[ "$BUMP" == pre* ]]; then
npm version "$BUMP" --no-git-tag-version --preid="$PREID"
npm version "$BUMP" --no-git-tag-version --preid="$PREID" --workspaces-update=false
else
npm version "$BUMP" --no-git-tag-version
npm version "$BUMP" --no-git-tag-version --workspaces-update=false
fi
NEW=$(node -p "require('./package.json').version")
VERSIONS+=" $pkg:$NEW"
Expand Down
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
"private": true,
"version": "0.1.0",
"packageManager": "pnpm@10.17.1",
"workspaces": [
"packages/*"
],
"devDependencies": {
"@types/node": "^22.18.0",
"agent-trajectories": "^0.5.3",
Expand Down
Loading