feat(persona-kit): add adapter config passthrough#239
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
📝 WalkthroughWalkthroughAdds an optional ChangesAdapter config passthrough and materialization typing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
There was a problem hiding this comment.
Code Review
This pull request introduces a forward-compatible config field to the integration connection configuration in persona-kit, allowing provider-specific configurations (such as GitHub materialization policies) to be defined and validated. The changes include JSON schema updates, TypeScript type definitions for GitHub materialization policies, parsing logic to ensure config is a plain object, and comprehensive test coverage. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
|
pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
3 similar comments
|
pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
|
pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
|
pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
92275c2 to
0028595
Compare
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
|
ℹ️ pr-reviewer: review only — no file changes were applied to the PR (nothing to commit after review). The notes below are advisory and were not pushed. pr-reviewer could not complete review for #239 in AgentWorkforce/workforce. |
Summary
integrations.<provider>.configadapter passthrough to persona-kit specsdefinePersona, using canonicallazy/eagermodes@relayfile/adapter-core@^0.3.50so typed scope keys include GitLabprojectPathThis supports AgentWorkforce/relayfile-adapters PR #193 and PR #194 so typed personas can declare GitHub/GitLab materialization policy, including eager issue/PR/MR resources for selected repos/projects.
Validation
git diff --checkcorepack pnpm --filter @agentworkforce/persona-kit test(283 pass, 0 fail)No persona-kit package version was changed.