feat: [BE] Support country filter on the get top-ups endpoint for the universal sim "GET/v2/sims/:iccid/topups" in SDK (AP-7797)

[kminanov]

Support country filter on the get top-ups endpoint to filter out top-ups for the universal sim "GET/v2/sims/:iccid/topups" in SDK (AP-7797)
Add get_universal_packages function to return only universal packages

[gemini-code-assist]

Summary of Changes

Hello @kminanov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the SDK's capabilities by introducing a country-based filtering option for universal SIM top-ups and a dedicated method for retrieving universal packages. These additions provide more granular control and improved usability when interacting with SIM and package data, particularly for universal eSims.

Highlights

• Country Filter for SIM Top-ups: The get_sim_topups endpoint now supports an optional iso2_country_code parameter, allowing users to filter top-ups specifically for universal SIMs by country.
• New Universal Packages Function: A new function, get_universal_packages, has been introduced to facilitate fetching only universal packages, enhancing package retrieval specificity.
• Documentation Updates: The README.md has been updated to reflect the new get_universal_packages function and the added iso2_country_code parameter for get_sim_topups.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two main features: filtering top-ups by country for universal SIMs and adding a method to fetch universal packages. The changes are well-implemented and include corresponding documentation and test updates.

My review focuses on improving documentation clarity and code maintainability. I've suggested updates to the README.md to provide a better example for the new filtering capability. I've also pointed out some inconsistencies in docstrings regarding the purpose of the get_sim_topups function (fetching available top-ups vs. history) and suggested corrections. Additionally, I've proposed a small refactoring in the URL construction logic to make it more robust and extensible for future query parameters.

Overall, this is a good contribution that enhances the SDK's functionality.