Skip to content

Override manual-review with --yes switch #199

Description

@UncleSamSwiss

When you try to run the release script and the manual-review plugin is enabled (by config file), it is not possible to override it with the --yes switch (see below).

For the ioBroker developer portal it would be helpful to be able to skip the manual review when the script is called from the web interface (as the user has no way to verify the current changes).

I know, every adapter could simply disable the manual-review plugin, but I think that defeats the purpose.

My suggestion is to allow the manual-review plugin to skip the question "Are you done?" when the --yes switch is set.

Alternatively, an additional --silent option or a way to disable a plugin on the command line would also solve the problem.

Log output:

iobroker@iobroker-loxone:/workspace$ npm run release -- --yes

> iobroker.loxone@4.0.1 release
> release-script --yes

check:git git status ok ✔
check:package package.json ok ✔
check:changelog changelog ok ✔
check:iobroker io-package.json ok ✔
check:version Bumping version from 4.0.1 to 4.0.2 ✔

edit:package updating package.json version from 4.0.1 to 4.0.2
edit:changelog Updating changelog in README.md
edit:iobroker updating io-package.json version to 4.0.2
edit:iobroker updating news in io-package.json
edit:iobroker adding new news to io-package.json

commit:manual-review Please review the changes and correct them manually if necessary.
? Are you done? … 
▸ no
  yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions