Documentation update for ServerTrustPolicyManager#718
Closed
sai-prasanna wants to merge 2 commits intoAlamofire:masterfrom
Closed
Documentation update for ServerTrustPolicyManager#718sai-prasanna wants to merge 2 commits intoAlamofire:masterfrom
sai-prasanna wants to merge 2 commits intoAlamofire:masterfrom
Conversation
Add a example to show how `ServerTrustPolicyManager` class can be sub-classed and `func serverTrustPolicyForHost` be overridden to implement more flexible evaluation for ServerTrustPolicy
Add documentation for Custom ServerTrustPolicyManager
Member
|
Thanks for your PR @sai-prasanna! Much appreciated. This task was actually sitting in our Trello backlog. I pushed a modified version of your PR in 282eec6 while still giving you attribution. Thanks again for your changes! 🍻 |
Contributor
Author
|
Great, btw I am new to contributing to open source, any suggestions on how to properly contribute to documentations, source code etc. Thanks |
Member
|
@sai-prasanna, the only suggestion I have would be to look at the diff between what you submitted and what I actually committed. That will help you find the differences in phrasing, code structure, etc. Otherwise, just keep the PRs coming...best way to learn is to practice! 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add example on how
ServerTrustPolicyManagercan be subclassed andserverTrustPolicyForHostbe overridden