Implement mini-editor#93
Conversation
|
Warning Review limit reached
More reviews will be available in 37 minutes and 25 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR introduces a compact editor window mode alongside the existing expanded dialog editor. The change adds editor-expansion state tracking, backend dual-mode support through new controller slots, and a complete compact editor UI with histogram and adjustment controls, coordinated via menu actions and keyboard shortcuts. ChangesCompact Editor and Dual-Mode Editing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b07bc283d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| self.ui_state.isEditorOpen | ||
| and self.ui_state.isEditorExpanded | ||
| ): | ||
| self.ui_state.isEditorOpen = False |
There was a problem hiding this comment.
Keep compact editor loaded after saving
When saving from the compact editor, editor_was_open is true but isEditorExpanded is false, so this new guard leaves the compact window visible while the following self.image_editor.clear() still unloads the backing image. Because CompactEditorWindow.ensureEditorLoaded() only reloads when currentIndex changes, any subsequent slider movement after a successful Save in the still-open compact editor calls set_edit_parameter() against a cleared editor and is ignored until the user closes/reopens or navigates away.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@faststack/app.py`:
- Around line 1074-1083: handle_key_from_compact_editor currently constructs a
QKeyEvent then calls keybinder.handle_key_press directly, bypassing the widget's
eventFilter (and its _dialog_open and mode guards). Instead of calling
keybinder.handle_key_press(event), forward the QKeyEvent through the same event
pipeline used elsewhere so eventFilter runs (e.g., call self.eventFilter(self,
event) or post/send the event via QApplication.postEvent/sendEvent to this
widget) and remove the direct keybinder invocation; this ensures the same guards
and routing logic are applied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 43eeac72-9324-4868-904e-0c8651c78be9
📒 Files selected for processing (5)
faststack/app.pyfaststack/qml/CompactEditorWindow.qmlfaststack/qml/ImageEditorDialog.qmlfaststack/qml/Main.qmlfaststack/ui/provider.py
Editor is now small - and can be expanded if more controls are needed.
Summary by CodeRabbit
New Features
Bug Fixes