Skip to content

fix(User Form): Disable auto_submit on LocaleSelect#276

Merged
tvdeyen merged 1 commit intomainfrom
locale-select-disable-auto-submit
Apr 16, 2026
Merged

fix(User Form): Disable auto_submit on LocaleSelect#276
tvdeyen merged 1 commit intomainfrom
locale-select-disable-auto-submit

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 14, 2026

The default behavior of LocaleSelect is to auto submit the form. We do not want this for the user edit form.

Needs AlchemyCMS/alchemy_cms#3835

@tvdeyen tvdeyen added backport-to-8.0-stable Needs a back port to 8.0-stable backport-to-8.1-stable Needs a back port to 8.1-stable backport-to-8.2-stable Needs a back port to 8.2-stable labels Apr 14, 2026
@tvdeyen tvdeyen force-pushed the locale-select-disable-auto-submit branch from c9ada39 to b5314ae Compare April 14, 2026 09:58
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (4aabd0a) to head (82a2064).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          11       11           
  Lines         291      291           
=======================================
  Hits          287      287           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen requested a review from a team April 14, 2026 17:00
The default behavior of LocaleSelect is to auto submit
the form. We do not want this for the user edit form.
@tvdeyen tvdeyen force-pushed the locale-select-disable-auto-submit branch from b5314ae to 82a2064 Compare April 14, 2026 17:01
Copy link
Copy Markdown

@sascha-karnatz sascha-karnatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have to update the alchemy branch later.

@tvdeyen
Copy link
Copy Markdown
Member Author

tvdeyen commented Apr 15, 2026

LGTM. We have to update the alchemy branch later.

Thats why we need that approved first ;)

@tvdeyen tvdeyen removed backport-to-8.0-stable Needs a back port to 8.0-stable backport-to-8.1-stable Needs a back port to 8.1-stable labels Apr 16, 2026
@tvdeyen tvdeyen merged commit 14d82cd into main Apr 16, 2026
32 checks passed
@tvdeyen tvdeyen deleted the locale-select-disable-auto-submit branch April 16, 2026 16:02
@alchemycms-bot
Copy link
Copy Markdown

💔 All backports failed

Status Branch Result
8.2-stable The branch "8.2-stable" does not exist

Manual backport

To create the backport manually run:

backport --pr 276

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@alchemycms-bot
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
8.2-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tvdeyen added a commit that referenced this pull request Apr 16, 2026
[8.2-stable] Merge pull request #276 from AlchemyCMS/locale-select-disable-auto-submit
@alchemycms-bot alchemycms-bot bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.2-stable Needs a back port to 8.2-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants