Skip to content

Add Toggle HUDs toolbar command#314

Merged
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/toolbar-toggle-huds
Jun 15, 2026
Merged

Add Toggle HUDs toolbar command#314
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/toolbar-toggle-huds

Conversation

@gwigz

@gwigz gwigz commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Expose an optional "Toggle HUDs" button in the toolbar/toybox which can be added. This shows/hides HUD attachments, wrapping the existing View.ShowHUDAttachments/View.CheckHUDAttachments handlers.

The 18x18 toggle_hud.png icon is adapted from Phosphor Icons duo-tone cards-three glyph.

SCR-20260614-jjzy

Handy when you don't want to learn or reach for the awkward hotkey.

Expose a "Toggle HUDs" button in the toybox that shows/hides HUD
attachments, wrapping the existing `View.ShowHUDAttachments` /
`View.CheckHUDAttachments` handlers. The 18x18 `toggle_hud.png` icon is
adapted from Phosphor Icons toggle glyph.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A new toggle_hud toolbar command is introduced, wiring View.ShowHUDAttachments as the execute function and a new LLViewEnableHUDAttachments handler that disables the command when RLVa HUD locking is active. Matching icon texture entries and localization strings are added across three skins.

Changes

Toggle HUD Toolbar Command

Layer / File(s) Summary
Command definition and enable handler
indra/newview/app_settings/commands.xml, indra/newview/llviewermenu.cpp
toggle_hud command entry binds View.ShowHUDAttachments / View.CheckHUDAttachments / View.EnableHUDAttachments. LLViewEnableHUDAttachments::handleEvent returns false when RLVa's showhud behaviour is locked and LLPipeline::sShowHUDAttachments is true; registered in initialize_menus().
Icon textures and localization strings
indra/newview/skins/default/textures/textures.xml, indra/newview/skins/alchemy/textures/textures.xml, indra/newview/skins/gemini/textures/textures.xml, indra/newview/skins/default/xui/en/strings.xml
Adds Command_ToggleHUD_Icon texture entry pointing to toolbar_icons/toggle_hud.png (preload enabled) in all three skins; adds label string "Toggle HUDs" and tooltip string "Show or hide HUD attachments".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 Hip hop, a button appears in the bar,
To hide all the HUDs near and far!
RLVa says "no" when the locks are in play,
But otherwise toggle to your heart's delight today.
The rabbit has wired it — icons and strings,
Three skins get the icon on freshly-preloaded wings! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is missing the required Related Issues section and most of the pre-submission checklist items. Add a Related Issues section with a link to the relevant GitHub issue, and complete the checklist items (testing, style guidelines, documentation, dependent changes, contributing guidelines review).
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Toggle HUDs toolbar command' clearly and concisely describes the main change: introducing a new optional toolbar button for toggling HUD visibility.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RyeMutt RyeMutt added this to the NEXT milestone Jun 15, 2026
@RyeMutt RyeMutt merged commit 550b906 into AlchemyViewer:develop Jun 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants