Skip to content

Fix first few chars of UUIDs missing in profiles (#299)#319

Merged
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/fix-profile-key
Jun 15, 2026
Merged

Fix first few chars of UUIDs missing in profiles (#299)#319
RyeMutt merged 1 commit into
AlchemyViewer:developfrom
gwigz:gwigz/fix-profile-key

Conversation

@gwigz

@gwigz gwigz commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Works around a LLLineEditor quirk to fix #299.

The Key field in profiles uses a read-only LLLineEditor (likely so the UUID stays selectable). By default it places the cursor at the end of the text even though it's read-only, causing the first few characters of the key to get clipped out of view.

This initially anchors read-only line editors to the start of the text instead.

Other read-only line editors that should technically benefit:

  • group_key group UUID, same issue as the profile key
  • user_name/display_name long display or legacy names in profiles
  • pick_name/pick_location profile picks
  • view_subject/view_inventory_name/create_inventory_name group notices
  • edt_invname_* region environment inventory names

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9d99ee96-55df-496c-9785-de35f993a1ea

📥 Commits

Reviewing files that changed from the base of the PR and between 753e934 and e12645e.

📒 Files selected for processing (1)
  • indra/llui/lllineeditor.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced text cursor positioning in input fields. Cursor now correctly anchors based on field state during initialization and when content is updated, ensuring consistent behavior for read-only and editable text fields.

Walkthrough

LLLineEditor gains read-only-aware cursor placement in two locations: the constructor now calls setCursor(0) when mReadOnly is true instead of positioning at text end, and setText() similarly branches on mReadOnly to force the cursor to 0 for read-only fields while clamping to text length for editable ones.

Changes

LLLineEditor read-only cursor positioning

Layer / File(s) Summary
Read-only cursor anchoring in constructor and setText()
indra/llui/lllineeditor.cpp
Constructor branches on mReadOnly to call setCursor(0) instead of positioning at text end. setText() adds the same branch: read-only fields force cursor to 0; editable fields clamp to text length.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐇 A cursor once wandered to the end of the line,
In read-only fields, that caused quite a whine!
Now anchored at zero, it sits nice and neat,
The UUID shows whole — no missing feat!
sniff sniff The carrots of correctness taste sweet. 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the root cause, the fix applied, and identifies multiple other affected read-only line editors, but does not follow the provided template structure. Restructure the description to follow the template: add a Description section, properly link issue #299, and complete the checklist items.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the main issue (#299) about UUIDs being cut off in profiles, accurately summarizing the primary fix.
Linked Issues check ✅ Passed The code changes directly address issue #299 by fixing cursor positioning in read-only LLLineEditor fields to display UUIDs correctly from the start.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the LLLineEditor cursor positioning issue for read-only fields, directly addressing the reported UUID display problem.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gwigz gwigz marked this pull request as ready for review June 14, 2026 16:00
@gwigz

gwigz commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

fair number of read-only inputs this may have slightly different behavior

like any PR, close or request changes if you want -- not fussed if Alchemy want to take a different approach

@RyeMutt RyeMutt added this to the NEXT milestone Jun 15, 2026
@RyeMutt RyeMutt merged commit c90f302 into AlchemyViewer:develop Jun 15, 2026
20 of 22 checks passed
@gwigz gwigz deleted the gwigz/fix-profile-key branch June 15, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Displayed UUID in profile window is cut off

2 participants