Make test_scheduler more smart#278
Conversation
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 100 100
Lines 1419 1419
=======================================
Hits 1399 1399
Misses 20 20 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BENCHMARK RESULTS (AUTOGENERATED)ci-ubuntu-clangObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-gccObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-windowsObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
|
| #pragma once | ||
|
|
||
| #include <rpp/schedulers.hpp> | ||
|
|
There was a problem hiding this comment.
parameter state is passed by value and only copied once; consider moving it to avoid unnecessary copies
| #include <utility> | |
| { | ||
| public: | ||
| worker_strategy(std::shared_ptr<state> state) | ||
| : m_state{state} { } |
There was a problem hiding this comment.
parameter state is passed by value and only copied once; consider moving it to avoid unnecessary copies
| : m_state{state} { } | |
| : m_state{std::move(state} { } |
| { | ||
| public: | ||
| worker_strategy(std::shared_ptr<state> state) | ||
| : m_state{state} { } |
There was a problem hiding this comment.
parameter state is passed by value and only copied once; consider moving it to avoid unnecessary copies
| : m_state{state} { } | |
| : m_state{state)} { } |
|
Kudos, SonarCloud Quality Gate passed!
|








No description provided.