Skip to content

fix dynamic copy/move #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexInLog merged 1 commit into from
Mar 26, 2024
Merged

fix dynamic copy/move #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/rpp/rpp/observables/dynamic_observable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ namespace rpp::details::observables
{
}

dynamic_strategy(const dynamic_strategy&) = default;
dynamic_strategy(dynamic_strategy&&) noexcept = default;

template<rpp::constraint::observer_strategy<Type> ObserverStrategy>
void subscribe(observer<Type, ObserverStrategy>&& observer) const
{
Expand Down
3 changes: 0 additions & 3 deletions src/rpp/rpp/observables/observable.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ namespace rpp
{
}

observable(const observable&) = default;
observable(observable&&) noexcept = default;

/**
* @brief Subscribes passed observer to emissions from this observable.
*
Expand Down
3 changes: 0 additions & 3 deletions src/rpp/rpp/observers/dynamic_observer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ namespace rpp::details::observers
{
}

dynamic_strategy(const dynamic_strategy&) = default;
dynamic_strategy(dynamic_strategy&&) noexcept = default;

void set_upstream(const disposable_wrapper& d) noexcept { m_vtable->set_upstream(m_forwarder.get(), d); }

bool is_disposed() const noexcept { return m_vtable->is_disposed(m_forwarder.get()); }
Expand Down
6 changes: 0 additions & 6 deletions src/rpp/rpp/observers/observer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ namespace rpp::details
{
}

observer_impl(const observer_impl&) = default;
observer_impl(observer_impl&&) noexcept = default;

public:
using preferred_disposable_strategy = observers::none_disposable_strategy;

Expand Down Expand Up @@ -248,9 +245,6 @@ namespace rpp
{
}

observer(const observer&) = default;
observer(observer&&) noexcept = default;

dynamic_observer<Type> as_dynamic() &&
{
return dynamic_observer<Type>{std::move(*this)};
Expand Down