extend hooks a bit

.clang-tidy

@@ -1,5 +1,5 @@
 ---
-Checks:    'clang-diagnostic-*,clang-analyzer-*,-*,bugprone-*,concurrency-*,performance-*,-macro*,readability-identifier-naming,-bugprone-exception-escape'
+Checks:    '-*,clang-diagnostic-*,clang-analyzer-*,bugprone-*,-bugprone-exception-escape,concurrency-*,performance-*,-macro*,readability-identifier-naming'
 WarningsAsErrors: '*'
 HeaderFilterRegex: './src/.*'
 AnalyzeTemporaryDtors: false

.github/workflows/analyzers.yml

@@ -148,4 +148,3 @@ jobs:
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
       run: |
         sonar-scanner --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" --define sonar.scm.revision=${{ github.event.workflow_run.head_sha }} --define sonar.pullrequest.key=${{ steps.source-run-info.outputs.pullRequestNumber }} --define sonar.pullrequest.branch=${{ steps.source-run-info.outputs.sourceHeadBranch }} --define sonar.pullrequest.base=${{ steps.source-run-info.outputs.targetBranch }}
-

.github/workflows/comment_benchmarks_v2.yml

@@ -89,4 +89,3 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: ./gh-pages
-

.gitignore

@@ -15,4 +15,3 @@ CMakeUserPresets.json
 
 gen_docs/
 gen_images/
-

.pre-commit-config.yaml

@@ -10,11 +10,16 @@ repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.6.0
     hooks:
-    -   id: trailing-whitespace
-        require_serial: true
-    # -   id: end-of-file-fixer
-    -   id: check-yaml
-    -   id: check-added-large-files
+    -   id: check-added-large-files # prevents giant files from being committed.
+    -   id: check-case-conflict # checks for files that would conflict in case-insensitive filesystems.
+    -   id: check-merge-conflict # checks for files that contain merge conflict strings.
+    -   id: check-yaml # checks yaml files for parseable syntax.
+    -   id: detect-private-key # detects the presence of private keys.
+    -   id: end-of-file-fixer # ensures that a file is either empty, or ends with one newline.
+    -   id: fix-byte-order-marker # removes utf-8 byte order marker.
+    -   id: mixed-line-ending # replaces or checks mixed line ending.
+    -   id: requirements-txt-fixer # sorts entries in requirements.txt.
+    -   id: trailing-whitespace # trims trailing whitespace.
 
 -   repo: https://github.com/pre-commit/mirrors-clang-format
     rev: 'v18.1.3'
@@ -23,21 +28,3 @@ repos:
         args: ["-style=file", "-i"]
         types_or: [c++, c]
         require_serial: true
-
-# - repo: local
-#   hooks:
-#     - id: compile_json
-#       name: compile_json
-#       entry: cmake --preset=ci-coverage-clang
-#       always_run: true
-#       require_serial: true
-#       pass_filenames: false
-#       language: system
-
-# - repo: https://github.com/pocc/pre-commit-hooks
-#   rev: master
-#   hooks:
-#     - id: clang-tidy
-#       args: [--fix-errors, -config-file=.clang-tidy, "--checks=-*,bugprone-*,concurrency-*,performance-*", -p=build, ./src/*]
-#     #   files: src
-#       entry: /usr/local/opt/llvm/bin/clang-tidy

.vscode/extensions.json

@@ -4,4 +4,4 @@
         "ms-vscode.cmake-tools",
         "cschlosser.doxdocgen"
     ]
-}
+}

.vscode/settings.json

@@ -10,4 +10,4 @@
     "sonarlint.connectedMode.project": {
       "projectKey": "victimsnino_ReactivePlusPlus"
     }
-}
+}

cmake/dependencies.cmake

@@ -89,4 +89,4 @@ if (RPP_BUILD_BENCHMARKS)
   set_target_properties(nanobench PROPERTIES CXX_CPPCHECK "")
   set_target_properties(nanobench PROPERTIES FOLDER 3rdparty)
 
-endif()
+endif()

cmake/dev-mode.cmake

@@ -7,4 +7,4 @@
 
 if(CMAKE_EXPORT_COMPILE_COMMANDS)
     set(CMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
-endif()
+endif()

cmake/install-config.cmake.in

@@ -4,4 +4,4 @@ find_package(Threads REQUIRED)
 
 include("${CMAKE_CURRENT_LIST_DIR}/RPPTargets.cmake")
 
-check_required_components(RPP)
+check_required_components(RPP)

cmake/variables.cmake

@@ -55,4 +55,4 @@ if (RPP_DEVELOPER_MODE)
   if(RPP_ENABLE_COVERAGE)
     include(cmake/coverage.cmake)
   endif()
-endif()
+endif()

docs/readme.md

@@ -442,4 +442,4 @@ rpp::source::just(1,2,3)
 | rpp::ops::flat_map([](const rpp::constraint::observable_of_type<int> auto& observable) { // or just `const auto& observable`
 return observable | rpp::ops::filter([](int v){ return v % 2 == 0;});
 });
-```
+```

src/examples/rpp/CMakeLists.txt

@@ -6,4 +6,4 @@ add_subdirectory(linesfrombytes)
 
 if (RPP_BUILD_SFML_CODE)
     add_subdirectory(sfml)
-endif()
+endif()

src/examples/rpp/basic/CMakeLists.txt

@@ -3,4 +3,4 @@ add_executable(basic_sample
 )
 
 target_link_libraries(basic_sample PRIVATE RPP::rpp)
-set_target_properties(basic_sample PROPERTIES FOLDER Examples/rpp)
+set_target_properties(basic_sample PROPERTIES FOLDER Examples/rpp)

src/examples/rpp/basic/basic.cpp

@@ -13,4 +13,4 @@ int main() // NOLINT(bugprone-exception-escape)
         | rpp::operators::subscribe([](char v) { std::cout << v; });
 
     return 0;
-}
+}

src/examples/rpp/doxygen/CMakeLists.txt

@@ -6,4 +6,4 @@ foreach(SOURCE ${FILES})
     add_executable(${TARGET} ${SOURCE})
     target_link_libraries(${TARGET} PRIVATE rpp)
     set_target_properties(${TARGET} PROPERTIES FOLDER Examples/rpp/Doxygen)
-endforeach()
+endforeach()

src/examples/rpp/doxygen/as_blocking.cpp

@@ -18,4 +18,4 @@ int main() // NOLINT(bugprone-exception-escape)
     std::cout << "done" << std::endl;
     // output: COMPLETED done
     //! [as_blocking]
-}
+}

src/examples/rpp/doxygen/concat.cpp

@@ -29,4 +29,4 @@ int main() // NOLINT(bugprone-exception-escape)
         | rpp::operators::subscribe([](int v) { std::cout << v << ", "; }, [](const std::exception_ptr&) {}, []() { std::cout << "completed\n"; });
     // Output: 1, 2, 1, 2, 3, completed
     //! [concat_as_operator]
-}
+}

src/examples/rpp/doxygen/connect.cpp

@@ -47,4 +47,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // observer value 5
     // DISPOSE
     //! [connect]
-}
+}

src/examples/rpp/doxygen/create.cpp

@@ -24,4 +24,4 @@ int main() // NOLINT(bugprone-exception-escape)
         .subscribe([](int v) { std::cout << v << std::endl; });
     // Output: 42
     //! [create with capture]
-}
+}

src/examples/rpp/doxygen/defer.cpp

@@ -39,4 +39,4 @@ int main() // NOLINT(bugprone-exception-escape)
     //         0
     //         On complete
     //! [defer mutable source]
-}
+}

src/examples/rpp/doxygen/filter.cpp

@@ -14,4 +14,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // Output: 0 2 4 6 8
     //! [Filter]
     return 0;
-}
+}

src/examples/rpp/doxygen/first.cpp

@@ -29,4 +29,4 @@ int main()
     // Output: -x
     //! [first_empty]
     return 0;
-}
+}

src/examples/rpp/doxygen/from.cpp

@@ -37,4 +37,4 @@ int main() // NOLINT(bugprone-exception-escape)
         //! [from_callable]
     }
     return 0;
-}
+}

src/examples/rpp/doxygen/interval.cpp

@@ -36,4 +36,4 @@ int main() // NOLINT(bugprone-exception-escape)
     //    emit 3 duration since start 25ms
     //    On complete
     //! [defer from_iterable]
-}
+}

src/examples/rpp/doxygen/last.cpp

@@ -29,4 +29,4 @@ int main()
     // Output: -x
     //! [last empty]
     return 0;
-}
+}

src/examples/rpp/doxygen/map.cpp

@@ -22,4 +22,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // Output: 42 VAL
     //! [Changed type]
     return 0;
-}
+}

src/examples/rpp/doxygen/repeat.cpp

@@ -29,4 +29,4 @@ int main()
     // Output: 1 2 3 1 2 3 1 2 3 1 completed
     //! [repeat_infinitely]
     return 0;
-}
+}

src/examples/rpp/doxygen/skip.cpp

@@ -14,4 +14,4 @@ int main()
     // Output: 2 3 4 5
     //! [skip]
     return 0;
-}
+}

src/examples/rpp/doxygen/start_wih.cpp

@@ -30,4 +30,4 @@ int main()
     //! [start_with_observable_as_value]
 
     return 0;
-}
+}

src/examples/rpp/doxygen/take.cpp

@@ -14,4 +14,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // Output: 0 1
     //! [take]
     return 0;
-}
+}

src/examples/rpp/doxygen/take_while.cpp

@@ -14,4 +14,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // Output: 0 1 2 3 4
     //! [take_while]
     return 0;
-}
+}

src/examples/rpp/doxygen/timeout.cpp

@@ -43,4 +43,4 @@ int main() // NOLINT(bugprone-exception-escape)
                                         });
         //! [default]
     }
-}
+}

src/examples/rpp/linesfrombytes/CMakeLists.txt

@@ -3,4 +3,4 @@ linesfrombytes.cpp
 )
 
 target_link_libraries(linesfrombytes PRIVATE RPP::rpp)
-set_target_properties(linesfrombytes PROPERTIES FOLDER Examples/rpp)
+set_target_properties(linesfrombytes PROPERTIES FOLDER Examples/rpp)

src/examples/rpp/linesfrombytes/linesfrombytes.cpp

@@ -74,4 +74,4 @@ int main() // NOLINT(bugprone-exception-escape)
     // print result
     lines | rpp::operators::subscribe([](const std::string& s) { std::cout << s << std::endl; });
     return 0;
-}
+}

src/examples/rpp/long_chain/CMakeLists.txt

@@ -3,4 +3,4 @@ add_executable(long_chain_sample
 )
 
 target_link_libraries(long_chain_sample PRIVATE RPP::rpp)
-set_target_properties(long_chain_sample PROPERTIES FOLDER Examples/rpp)
+set_target_properties(long_chain_sample PROPERTIES FOLDER Examples/rpp)

src/examples/rpp/package/CMakeLists.txt

@@ -5,4 +5,4 @@ find_package(RPP REQUIRED CONFIG)
 
 add_executable(${PROJECT_NAME} ../basic/basic.cpp)
 target_link_libraries(${PROJECT_NAME} PRIVATE RPP::rpp)
-target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_20)
+target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_20)

src/examples/rpp/sfml/CMakeLists.txt

@@ -1 +1 @@
-add_subdirectory(snake)
+add_subdirectory(snake)

src/examples/rpp/sfml/snake/CMakeLists.txt

@@ -19,4 +19,4 @@ if (WIN32)
   add_custom_command (TARGET ${TARGET} POST_BUILD  COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_FILE:sfml-graphics> $<TARGET_FILE_DIR:${TARGET}>)
   add_custom_command (TARGET ${TARGET} POST_BUILD  COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_FILE:sfml-system> $<TARGET_FILE_DIR:${TARGET}>)
   add_custom_command (TARGET ${TARGET} POST_BUILD  COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_FILE:sfml-window> $<TARGET_FILE_DIR:${TARGET}>)
-endif()
+endif()

src/examples/rpp/sfml/snake/canvas.cpp

@@ -19,4 +19,4 @@ sf::Vector2u get_window_size(size_t rows_count, size_t cols_count)
 {
     return {static_cast<uint32_t>(static_cast<float>(cols_count) * (s_cell_size + s_gap_size)),
             static_cast<uint32_t>(static_cast<float>(rows_count) * (s_cell_size + s_gap_size))};
-}
+}

src/examples/rpp/sfml/snake/canvas.hpp

@@ -5,4 +5,4 @@
 #include "snake.hpp"
 
 sf::RectangleShape get_rectangle_at(Coordinates location, sf::Color color);
-sf::Vector2u       get_window_size(size_t rows_count, size_t cols_count);
+sf::Vector2u       get_window_size(size_t rows_count, size_t cols_count);

src/examples/rpp/sfml/snake/main.cpp

@@ -82,4 +82,4 @@ int main()
     }
 
     return EXIT_SUCCESS;
-}
+}

src/examples/rpp/sfml/snake/snake.cpp

@@ -144,4 +144,4 @@ rpp::dynamic_observable<sf::RectangleShape> get_shapes_to_draw(const rpp::dynami
     return get_presents_stream(events)
          | rpp::ops::with_latest_from([](const auto&, const auto& v) { return v; }, drawable_objects)
          | rpp::ops::switch_on_next();
-}
+}

src/examples/rpp/sfml/snake/snake.hpp

@@ -4,4 +4,4 @@
 
 #include "utils.hpp"
 
-rpp::dynamic_observable<sf::RectangleShape> get_shapes_to_draw(const rpp::dynamic_observable<CustomEvent>& events);
+rpp::dynamic_observable<sf::RectangleShape> get_shapes_to_draw(const rpp::dynamic_observable<CustomEvent>& events);

src/examples/rpp/sfml/snake/utils.hpp

@@ -36,4 +36,4 @@ auto get_presents_stream(const auto& events)
 {
     return events | rpp::ops::filter([](const CustomEvent& ev) { return std::holds_alternative<PresentEvent>(ev); })
          | rpp::ops::map([](const CustomEvent& ev) { return std::get<PresentEvent>(ev); });
-}
+}

src/examples/rpp/two_async_streams/CMakeLists.txt

@@ -3,4 +3,4 @@ add_executable(two_async_streams
 )
 
 target_link_libraries(two_async_streams PRIVATE RPP::rpp)
-set_target_properties(two_async_streams PROPERTIES FOLDER Examples/rpp)
+set_target_properties(two_async_streams PROPERTIES FOLDER Examples/rpp)

src/examples/rpp/two_async_streams/two_async_streams.cpp

@@ -51,4 +51,4 @@ int main() // NOLINT(bugprone-exception-escape)
     std::cout << "EXIT" << std::endl;
 
     return 0;
-}
+}

src/examples/rppqt/basic/CMakeLists.txt

@@ -2,4 +2,3 @@ add_executable(basic_rppqt basic_rppqt.cpp)
 target_link_libraries(basic_rppqt PRIVATE rpp rppqt)
 set_target_properties(basic_rppqt PROPERTIES FOLDER Examples/rppqt)
 rpp_add_qt_support_to_executable(basic_rppqt)
-

src/examples/rppqt/basic/basic_rppqt.cpp

@@ -48,4 +48,4 @@ int main(int argc, char* argv[])
     window.show();
 
     return app.exec();
-}
+}

src/examples/rppqt/doxygen/CMakeLists.txt

@@ -8,4 +8,3 @@ foreach(SOURCE ${FILES})
     set_target_properties(${TARGET} PROPERTIES FOLDER Examples/rppqt/Doxygen)
     rpp_add_qt_support_to_executable(${TARGET})
 endforeach()
-

src/rpp/rpp/defs.hpp

@@ -21,4 +21,4 @@
     #define RPP_NO_UNIQUE_ADDRESS [[msvc::no_unique_address]]
 #else
     #define RPP_NO_UNIQUE_ADDRESS [[no_unique_address]]
-#endif
+#endif

src/rpp/rpp/disposables/callback_disposable.hpp

@@ -48,4 +48,4 @@ namespace rpp
     {
         return disposable_wrapper::make<rpp::callback_disposable<std::decay_t<Fn>>>(std::forward<Fn>(invocable));
     }
-} // namespace rpp
+} // namespace rpp

src/rpp/rpp/disposables/details/base_disposable.hpp

@@ -49,4 +49,4 @@ namespace rpp::details
 
     using base_disposable           = base_disposable_impl<interface_disposable>;
     using base_composite_disposable = base_disposable_impl<interface_composite_disposable>;
-} // namespace rpp::details
+} // namespace rpp::details