fix: reuse shared AudioContext to prevent resource leak#48
Merged
AlexPeppas merged 1 commit intomasterfrom Apr 4, 2026
Merged
Conversation
Each call to playBell() created a new AudioContext that was never closed. AudioContexts are limited OS resources (~6-8 per origin) and accumulate until the Electron renderer hits the browser limit. Reuse a single module-level instance and resume it if suspended by autoplay policy. Closes #46
AlexPeppas
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playBell()created a newAudioContexton every call — these are limited OS resources (~6-8 per origin) that were never closedAudioContextthat is lazily created and reusedresume()if the context is suspendedCloses #46
Test plan
WaitingForInput) and verify audio still plays