fix: restrict shell.openPath IPC to known session directories#50
Merged
AlexPeppas merged 1 commit intomasterfrom Apr 4, 2026
Merged
fix: restrict shell.openPath IPC to known session directories#50AlexPeppas merged 1 commit intomasterfrom
AlexPeppas merged 1 commit intomasterfrom
Conversation
The SHELL_OPEN_PATH handler passed arbitrary renderer-supplied paths to Electron's shell.openPath(), which opens files/URLs with the OS default handler. A compromised renderer could use this to execute arbitrary applications. Now validates that the resolved path is: 1. A known session working directory 2. An existing directory on disk Closes #49
AlexPeppas
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fix — the
SHELL_OPEN_PATHIPC handler passed arbitrary renderer-supplied paths to Electron'sshell.openPath(), which opens files/URLs using the OS default handler. A compromised renderer could exploit this to execute arbitrary applications, scripts, or URL schemes.sessionManager.list()The only call site is
ExplorerPanel.tsxwhich opens a session's cwd in Finder/Explorer — this behavior is preserved.Closes #49
Test plan
window.agentPlex.openPath('/Applications')from DevTools is rejectedwindow.agentPlex.openPath('/path/to/some/executable')is rejectedwindow.agentPlex.openPath('https://evil.com')is rejected