lcp_int returns wrong result

[AndreasEisele]

lcp_int returned an array with no useful data (constant zeros).
I had a look into the code and found a suspicious line:

PySAIS/pysais.c

Line 290 in bc27f42

T = pyvector_to_Carrayptrs(SA_np);

T = pyvector_to_Carrayptrs(SA_np);

This looks obviously wrong. Correcting it to
T = pyvector_to_Carrayptrs(T_np);

gives me better results.

Now I am wondering, am I the first one to even use this function? Might there be other glitches hidden noone ever found due to lack of testing? Is this project still alive? It would be a pity of not, because I think it is really cool!

Best regards and thanks, Andreas

[AlexeyG]

Hi Andreas,

It indeed looks like you spotted a bug! I haven't been working on the project for some time, but you're very welcome to implement the fix and submit a PR. If you're willing to add a couple of tests, even better ;)

Thanks,
Alexey