Add barrel track propagation to PV at AOD creation stage by nburmaso · Pull Request #11458 · AliceO2Group/AliceO2

nburmaso · 2023-06-08T11:52:32Z

Here is an implementation of (barrel) tracks propagation. It is similar to the track propagation task:

tracks with x > 83.1 cm are not propagated
if a track has been propagated successfully then it's type is set to aod::track::Track, aod::track::TrackIU otherwise
track propagation can be enabled via option --propagate-tracks
tracks are propagated using cov matrix if --propagate-tracks-cov is passed (in addition to --propagate-tracks)
tracks used by the secondary vertexer are skipped

Please let me know if you have any suggestions

Nazar

shahor02 · 2023-06-08T12:04:10Z

+  void fetchMeanVtxCCDB(int runNumber)
+  {
+    static int prevRunNumber = -1;
+    if (runNumber == prevRunNumber)
+      return;
+    auto& ccdbMgr = o2::ccdb::BasicCCDBManager::instance();
+    std::map<std::string, std::string> headers, metadataRCT;
+    headers = mCCDBAPI.retrieveHeaders(Form("RCT/Info/RunInformation/%i", runNumber), metadataRCT, -1);
+    int64_t ts = std::atol(headers["SOR"].c_str()); // timestamp in ms
+    mVtx = ccdbMgr.getForTimeStamp<o2::dataformats::MeanVertexObject>(mVtxPath, ts);
+    prevRunNumber = runNumber;
+  }
+


Please don't use ccdb manager but use the DPL fetcher, e.g. like:

AliceO2/Detectors/GlobalTrackingWorkflow/src/PrimaryVertexingSpec.cxx

Line 241 in b487141

dataRequest->inputs.emplace_back("meanvtx", "GLO", "MEANVERTEX", 0, Lifetime::Condition, ccdbParamSpec("GLO/Calib/MeanVertex", {}, 1));

AliceO2/Detectors/GlobalTrackingWorkflow/src/PrimaryVertexingSpec.cxx

Line 212 in b487141

pc.inputs().get<o2::dataformats::MeanVertexObject*>("meanvtx");

AliceO2/Detectors/GlobalTrackingWorkflow/src/PrimaryVertexingSpec.cxx

Line 180 in b487141

if (matcher == ConcreteDataMatcher("GLO", "MEANVERTEX", 0)) {

shahor02 · 2023-06-08T12:12:05Z

+      mGIDUsedBySVtx.insert(id3Body.getProngID(0));
+      mGIDUsedBySVtx.insert(id3Body.getProngID(1));
+      mGIDUsedBySVtx.insert(id3Body.getProngID(2));
+    }


Note that now we also going to have the strangeness tracking: fmazzasc@3715b20

shahor02 · 2023-06-08T12:12:45Z

+                                                const o2::globaltracking::RecoContainer& data,
+                                                int colID)
+{
+  if (trackPar.getX() > mMinPropR)


shahor02 · 2023-06-08T12:14:17Z

            continue;
          }
-          addToTracksTable(tracksCursor, tracksCovCursor, data.getTrackParam(trackIndex), collisionID);
+          o2::track::TrackParametrizationWithError<float> trackPar = data.getTrackParam(trackIndex);


here you create a track copy and check for the getX() > Xtpc only in the propagateTrackToPV. It would be faster to 1st check if the track should be propagated then to create its copy

shahor02 · 2023-06-08T12:14:52Z

+  if (mPropTracks) {
+    mCCDBAPI.init(mCCDBUrl);
+    auto& ccdbMgr = o2::ccdb::BasicCCDBManager::instance();
+    ccdbMgr.setURL(mCCDBUrl);
+    ccdbMgr.setCaching(true);
+    ccdbMgr.setLocalObjectValidityChecking();
+  }


don't use the manager, see above.

shahor02 · 2023-06-08T12:19:22Z

+  if (colID >= 0) {
+    const auto& vtx = data.getPrimaryVertex(colID);
+    v.setPos({vtx.getXYZ()});
+    if (mPropTracksCov) {
+      v.setCov({vtx.getCov()});
+    }
+  } else {
+    v.setPos({mVtx->getXYZ()});
+    if (mPropTracksCov) {
+      v.setCov(mVtx->getSigmaX() * mVtx->getSigmaX(),
+               0.f,
+               mVtx->getSigmaY() * mVtx->getSigmaY(),
+               0.f,
+               0.f,
+               mVtx->getSigmaZ() * mVtx->getSigmaZ());
+    }
+  }


The MeanVertex is in general Z-dependent (the beams have some angles), use just

o2::dataformats::VertexBase v = mVtx.getMeanVertex( colID < 0 ? 0.f : data.getPrimaryVertex(colID).getZ());

shahor02 · 2023-06-08T12:20:44Z

+               mVtx->getSigmaZ() * mVtx->getSigmaZ());
+    }
+  }
+  return o2::base::Propagator::Instance()->propagateToDCABxByBz(v, trackPar, 2.f, mMatCorr, &dcaInfo);


Not sure what is the point of mPropTracksCov option? You are always propagating the cov.matrix.

nburmaso · 2023-06-08T12:26:05Z

Thank you for the comments @shahor02! I will fix the code and ping you back :)

nburmaso · 2023-06-08T13:09:59Z

@shahor02, I have tried fixing the code according to your suggestions. Could you please take a look when you have a moment?

shahor02

Thanks @nburmaso
please see 1 comment below, the rest looks fine,

shahor02 · 2023-06-08T13:28:12Z

+          o2::track::TrackParametrizationWithError<float> trackPar;
+          bool isProp = false;
+          if (mPropTracks && trackPar.getX() < mMinPropR) {


Now you have the trackPar undefined before the check :).
I would do:

const auto& trOrig = data.getTrackParam(trackIndex); bool isProp = false; if (mPropTracks && trOrig.getX() < mMinPropR) { auto trackPar(trOrig); if (isProp = propagateTrackToPV(trackPar, data, collisionID)) { addToTracksTable(tracksCursor, trackPar, collisionID, aod::track::Track); } } if (!isProp) { addToTracksTable(tracksCursor, tracksCovCursor, trOrig, collisionID, aod::track::TrackIU); }

Thank you @shahor02, this looks better indeed :)

alibuild · 2023-06-08T14:04:47Z

Error while checking build/O2/fullCI for 38887fc at 2023-06-08 16:04:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/11458-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:447:73: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/11458-slc8_x86-64/0/Detectors/AOD/src/AODProducerWorkflowSpec.cxx:2362:35: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

shahor02

now looks ok to me

jgrosseo · 2023-06-12T08:11:07Z

Thanks a lot for this work. I have no additional comments.

…p#11458) * Add barrel track propagation to PV at AOD creation stage

This feature was introduced in AliceO2Group#11458, however the additional check for SV was forgotten. This is anyways not enabled by default and should not have affected any default production.

This feature was introduced in #11458, however the additional check for SV was forgotten. This is anyways not enabled by default and should not have affected any default production.

This feature was introduced in AliceO2Group#11458, however the additional check for SV was forgotten. This is anyways not enabled by default and should not have affected any default production.

Add barrel track propagation to PV at AOD creation stage

38887fc

nburmaso requested a review from a team as a code owner June 8, 2023 11:52

shahor02 requested changes Jun 8, 2023

View reviewed changes

Various improvements

268e858

shahor02 reviewed Jun 8, 2023

View reviewed changes

Fix propagation conditions and avoid copy

2520048

shahor02 approved these changes Jun 8, 2023

View reviewed changes

sawenzel merged commit 01ce2f5 into AliceO2Group:dev Jun 13, 2023

mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Aug 24, 2023

Add barrel track propagation to PV at AOD creation stage (AliceO2Grou…

c6df3ee

…p#11458) * Add barrel track propagation to PV at AOD creation stage

f3sch mentioned this pull request Dec 7, 2023

AODPRODUCER: disable propagation to PV for SV #12415

Merged

Uh oh!

Conversation

nburmaso commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nburmaso commented Jun 8, 2023

Uh oh!

nburmaso commented Jun 8, 2023

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alibuild commented Jun 8, 2023

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

jgrosseo commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

nburmaso commented Jun 8, 2023 •

edited

Loading

jgrosseo commented Jun 12, 2023 •

edited

Loading